Issue 3071013: Revert "Revert 53989 - Implement new mock for user options page per chromium-os:5028"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3071013: Revert "Revert 53989 - Implement new mock for user options page per chromium-os:5028" (Closed)

Created:
10 years, 4 months ago by xiyuan

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, dhg, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Revert "Revert 53989 - Implement new mock for user options page per chromium-os:5028" This reverts commit r54128. TBR=dhg@chromium.org BUG=chromium-os:5028 TEST=erify the user options page matches mock per chromium-os:5028. Note the underlying libcros is still missing and UI shows up mock data only. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54566

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+216 lines, -71 lines)			Patch
M	chrome/app/generated_resources.grd	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/cros_settings_names.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros_settings_names.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/accounts_options_handler.cc	View	1 chunk	+8 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/mock_cros_settings.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/options_ui.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos_accounts_options.html	View	2 chunks	+18 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos_accounts_options.js	View	2 chunks	+16 lines, -11 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos_accounts_options_page.css	View	1 chunk	+65 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos_accounts_user_list.js	View	3 chunks	+81 lines, -24 lines	0 comments	Download