Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3071012: Cleanup: Remove unneeded headers from base/ (part 1) (Closed)

Created:
10 years, 4 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, John Grabowski, amit, kuchhal, cbentzel+watch_chromium.org, fbarchard, nkostylev+cc_chromium.org, idana, Erik does not do reviews, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), ben+cc_chromium.org, Raghu Simha, Paul Godavari, ncarter (slow), pam+watch_chromium.org, awong, scherkus (not reviewing), Alpha Left Google, Aaron Boodman, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

FBTF: Remove unneeded headers from base/ (part 1) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55034

Patch Set 1 : '' #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -95 lines) Patch
M app/resource_bundle_dummy.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M app/win_util.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/crypto/symmetric_key_mac.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/file_path.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M base/message_pump_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/process_util_posix.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M base/shared_memory_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/trace_event_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/win_util_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/breakpad_linux.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_dll_main.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_accessibility_manager_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_accessibility_win.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_main.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/google_authenticator.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/diagnostics/diagnostics_main.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/download/download_manager.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_updater.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_updater_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/google_update_settings_posix.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/extension_install_prompt2_gtk.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/extension_install_prompt_gtk.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/icon_loader.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profile.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_restore_uitest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/views/about_chrome_view.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/extensions/extension_install_prompt.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/first_run_bubble.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_drag_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_paths_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/sandbox_policy.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/chrome_frame_distribution.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/selenium/selenium_test.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome_frame/bho.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome_frame/bho.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome_frame/chrome_active_document.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/chrome_frame_activex.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome_frame/chrome_frame_npapi.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/protocol_sink_wrap.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/html_util_unittests.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome_frame/test/ie_event_sink.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/navigation_test.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome_frame/test/reliability/page_load_test.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome_frame/test/test_server.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome_frame/test/ui_test.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome_frame/urlmon_moniker.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/urlmon_url_request.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
MM media/tools/mfdecoder/main.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_session.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/src/dep.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/src/process_thread_dispatcher.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/src/registry_policy.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M views/controls/listbox/native_listbox_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
The cleanup train chugs along...
10 years, 4 months ago (2010-08-03 02:49:24 UTC) #1
Elliot Glaysher
10 years, 4 months ago (2010-08-03 17:16:37 UTC) #2 
On 2010/08/03 02:49:24, Lei Zhang wrote:
> The cleanup train chugs along...

LGTM. Maybe prefix the description with FBTF like the GTTF does?

Powered by Google App Engine
This is Rietveld 408576698