Issue 3071011: GTTF: Add more logging to BrowserKeyboardAccessibility test...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3071011: GTTF: Add more logging to BrowserKeyboardAccessibility test... (Closed)

Created:
10 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli, David Tseng

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

GTTF: Add more logging to BrowserKeyboardAccessibility test to help debug hangs and crashes. Using LOG(ERROR) to make sure the output will be always visible and captured on Windows. We need the logs. The issue is hard to reproduce. TEST=BrowserKeyboardAccessibility BUG=50663 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54404

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	chrome/browser/views/browser_keyboard_accessibility_test_win.cc	View		4 chunks	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

David Tseng

10 years, 4 months ago (2010-07-30 22:54:27 UTC) #3

LGTM

On 7/30/10, jcivelli@chromium.org <jcivelli@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/3071011/show
>

Expand Messages | Collapse Messages