Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chrome/test/ui_test_utils.cc

Issue 3071005: Download code cleanup patch of death: (Closed)
Patch Set: inline the dtor Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui_test_utils.cc
diff --git a/chrome/test/ui_test_utils.cc b/chrome/test/ui_test_utils.cc
index eb992b6b94fb5c7600785348eec004436c3b88ca..8e11ebffa12e1a11d6be38ae2bce304b5dc07bf9 100644
--- a/chrome/test/ui_test_utils.cc
+++ b/chrome/test/ui_test_utils.cc
@@ -168,7 +168,7 @@ class DownloadsCompleteObserver : public DownloadManager::Observer,
download_manager_->RemoveObserver(this);
// waiting_ will have been set if not all downloads were complete on first
- // pass below in SetDownloads().
+ // pass below in OnSearchDownloadsComplete().
if (waiting_)
MessageLoopForUI::current()->Quit();
return true;
@@ -186,10 +186,13 @@ class DownloadsCompleteObserver : public DownloadManager::Observer,
// DownloadManager::Observer
virtual void ModelChanged() {
- download_manager_->GetDownloads(this, L"");
+ download_manager_->download_history()->Search(
+ string16(),
+ NewCallback(this,
+ &DownloadsCompleteObserver::OnSearchDownloadsComplete));
}
- virtual void SetDownloads(std::vector<DownloadItem*>& downloads) {
+ void OnSearchDownloadsComplete(std::vector<DownloadItem*> downloads) {
downloads_ = downloads;
if (CheckAllDownloadsComplete())
return;
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698