Re-added chrome test dependencies to the build again.

Re-added chrome test dependencies to the build again.

[zel, 2010-07-27 23:31:58]

there is a chance this will break the build again (i.e. stateful partition size
overflow), but there is not other way to test it (once it passes 'git try')

[davidjames, 2010-07-27 23:36:42]

Could you run this through a complete build? I.e., actually build the image and
mod it for test? If Chrome test are too big, that step will fail.

[zel, 2010-07-27 23:59:09]

I ran it through the complete build + image creation. I did that with my
original CL as well (non-factory install).

Btw, how do we build factory install image on bbots? Do we just pass
--factory_install to build_image? Any other params there?

On Tue, Jul 27, 2010 at 4:36 PM, <davidjames@chromium.org> wrote:

> Could you run this through a complete build? I.e., actually build the image
> and
> mod it for test? If Chrome test are too big, that step will fail.
>
>
> http://codereview.chromium.org/3071004/show
>

[davidjames, 2010-07-28 00:37:35]

On 2010/07/27 23:59:09, zel wrote:
> I ran it through the complete build + image creation. I did that with my
> original CL as well (non-factory install).
> 
> Btw, how do we build factory install image on bbots? Do we just pass
> --factory_install to build_image? Any other params there?

You can see the official params to the buildbot for the failing build here:
 
http://build.chromium.org/buildbot/chromiumos/builders/x86%20generic%20full%2...

If you follow the same steps as the failing build, you should see the same
failure. You can see the commands that the buildbot ran at the top of each step.
(E.g., for archive_build, it lists the options.) For archive_build, you can
probably skip the gsutil_archive, gsd_gen_index, and gsutil options

[zel, 2010-07-28 01:12:22]

OK, this CL still seems happy.


On Tue, Jul 27, 2010 at 5:37 PM, <davidjames@chromium.org> wrote:

> On 2010/07/27 23:59:09, zel wrote:
>
>> I ran it through the complete build + image creation. I did that with my
>> original CL as well (non-factory install).
>>
>
>  Btw, how do we build factory install image on bbots? Do we just pass
>> --factory_install to build_image? Any other params there?
>>
>
> You can see the official params to the buildbot for the failing build here:
>
>
>
http://build.chromium.org/buildbot/chromiumos/builders/x86%20generic%20full%2...
>
> If you follow the same steps as the failing build, you should see the same
> failure. You can see the commands that the buildbot ran at the top of each
> step.
> (E.g., for archive_build, it lists the options.) For archive_build, you can
> probably skip the gsutil_archive, gsd_gen_index, and gsutil options
>
>
>
>
>
>
> http://codereview.chromium.org/3071004/show
>

[Nick Sanders, 2010-07-28 01:24:52]

lgtm, 
assuming build with "./mod_image_for_test.sh --factory" passes ok?

[zel, 2010-07-28 01:36:42]

Yes, it does pass on my machine.

On Tue, Jul 27, 2010 at 6:24 PM, <nsanders@chromium.org> wrote:

> lgtm,
> assuming build with "./mod_image_for_test.sh --factory" passes ok?
>
>
> http://codereview.chromium.org/3071004/show
>