Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3300)

Unified Diff: build/common.gypi

Issue 307032: Fix coverage on the Mac. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 29490)
+++ build/common.gypi (working copy)
@@ -311,10 +311,10 @@
'GCC_INSTRUMENT_PROGRAM_FLOW_ARCS': 'YES', # -fprofile-arcs
'GCC_GENERATE_TEST_COVERAGE_FILES': 'YES', # -ftest-coverage
},
- # Add -lgcov for executables, not for static_libraries.
- # This is a delayed conditional.
+ # Add -lgcov for executables and shared_libraries, not for
+ # static_libraries. This is a delayed conditional.
'target_conditions': [
- ['_type=="executable"', {
+ ['_type=="executable" or _type=="shared_library"', {
'xcode_settings': { 'OTHER_LDFLAGS': [ '-lgcov' ] },
}],
],
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698