Issue 3069033: Add a location bar icon for accessed (but not blocked) cookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3069033: Add a location bar icon for accessed (but not blocked) cookies. (Closed)

Created:
10 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Visibility:
Public.

Description

Add a location bar icon for accessed (but not blocked) cookies. BUG=45230 TEST=none TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55199

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	A	chrome/app/theme/accessed_cookies.png	View		Binary file		0 comments	Download
	M	chrome/app/theme/theme_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

10 years, 4 months ago (2010-08-06 16:53:53 UTC) #2

ok

On Fri, Aug 6, 2010 at 1:24 AM, <jochen@chromium.org> wrote:

> Reviewers: Ben Goodger,
>
> Message:
> please review
>
> Description:
> Add a location bar icon for accessed (but not blocked) cookies.
>
> BUG=45230
> TEST=none
> TBR=ben@chromium.org
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55199
>
> Please review this at http://codereview.chromium.org/3069033/show
>
> Affected files:
>  A chrome/app/theme/accessed_cookies.png
>  M chrome/app/theme/theme_resources.grd
>
>
> Index: chrome/app/theme/accessed_cookies.png
> diff --git a/chrome/app/theme/accessed_cookies.png
> b/chrome/app/theme/accessed_cookies.png
> new file mode 100644
> index
>
0000000000000000000000000000000000000000..10a42d2af5c2ed6f1aedf5b7b8ff4be5b1d9a5e4
> Binary files /dev/null and b/chrome/app/theme/accessed_cookies.png differ
> Index: chrome/app/theme/theme_resources.grd
> diff --git a/chrome/app/theme/theme_resources.grd
> b/chrome/app/theme/theme_resources.grd
> index
>
e14bd07095599b0d59f3ab849425323f00b16ba6..ebcd87a70d552d2b541f77301067b1c3c17a8b69
> 100644
> --- a/chrome/app/theme/theme_resources.grd
> +++ b/chrome/app/theme/theme_resources.grd
> @@ -21,6 +21,7 @@
>         <include name="IDR_ABOUT_BACKGROUND_COLOR"
> file="chromium/about_background_color.png" type="BINDATA" />
>         <include name="IDR_ABOUT_BACKGROUND_RTL"
> file="chromium/about_background_rtl.png" type="BINDATA" />
>       </if>
> +      <include name="IDR_ACCESSED_COOKIES" file="accessed_cookies.png"
> type="BINDATA" />
>       <include name="IDR_APP_DROPARROW" file="app_droparrow.png"
> type="BINDATA" />
>       <include name="IDR_BACK" file="back.png" type="BINDATA" />
>       <include name="IDR_BACK_D" file="back_d.png" type="BINDATA" />
>
>
>

Expand Messages | Collapse Messages