Issue 3069031: build_image,cros_make_image_bootable: fix missing arm argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3069031: build_image,cros_make_image_bootable: fix missing arm argument (Closed)

Created:
10 years, 4 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
rjkroege, davidjames, Alexey Marinichev

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

build_image,cros_make_image_bootable: fix missing arm argument Adds arm_extra_bootargs to boot.desc and to cros_make_image_bootable. TEST=tegra2 dev-board build_packages, build_image --fast worked BUG=broken tree Change-Id: Ifdfeda66f1eb5e5b1e618706eeba269f31fa9913

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	bin/cros_make_image_bootable	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	build_image	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alexey Marinichev

LGTM On 2010/08/05 20:21:16, Will Drewry wrote: > +build sheriffs > > I am pending ...

10 years, 4 months ago (2010-08-05 20:27:16 UTC) #3

rjkroege

10 years, 4 months ago (2010-08-05 20:27:43 UTC) #4

On 2010/08/05 20:21:16, Will Drewry wrote:
> +build sheriffs
> 
> I am pending a tegra2 build now

For what it's worth, LGTM.

Expand Messages | Collapse Messages