EULA screen enabling/disabling crash/metrics reporting renovated....

chrome/browser/chromeos/login/eula_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/eula_view.h"
 
 #include <signal.h>
 #include <sys/types.h>
 #include <string>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/basictypes.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/customization_document.h"
 #include "chrome/browser/chromeos/login/network_screen_delegate.h"
 #include "chrome/browser/chromeos/login/rounded_rect_painter.h"
 #include "chrome/browser/chromeos/login/wizard_controller.h"
+#include "chrome/browser/options_util.h"
+#include "chrome/browser/pref_service.h"
 #include "chrome/browser/profile_manager.h"
 #include "chrome/browser/renderer_host/site_instance.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/views/dom_view.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/installer/util/google_update_settings.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "views/controls/button/checkbox.h"
 #include "views/controls/button/native_button.h"
 #include "views/controls/label.h"
 #include "views/grid_layout.h"
 #include "views/layout_manager.h"
 #include "views/standard_layout.h"
 
+#if defined(USE_LINUX_BREAKPAD)
+#include "chrome/app/breakpad_linux.h"
+#endif
+
 namespace {
 
 const int kBorderSize = 10;
 const int kMargin = 20;
 const int kLastButtonHorizontalMargin = 10;
 const int kCheckBowWidth = 22;
 const int kTextMargin = 10;
 
 // TODO(glotov): this URL should be changed to actual Google ChromeOS EULA.
 // See crbug.com/4647
@@ skipping 128 matching lines @@
   layout->AddView(box_view);
 
   google_eula_view_ = new DOMView();
   box_view->AddChildView(google_eula_view_);
 
   layout->AddPaddingRow(0, kRelatedControlSmallVerticalSpacing);
   layout->StartRow(0, SINGLE_CONTROL_WITH_SHIFT_ROW);
   usage_statistics_checkbox_ = new views::Checkbox();
   usage_statistics_checkbox_->SetMultiLine(true);
   usage_statistics_checkbox_->SetChecked(
-      GoogleUpdateSettings::GetCollectStatsConsent());
+      g_browser_process->local_state()->GetBoolean(
+          prefs::kMetricsReportingEnabled));
   layout->AddView(usage_statistics_checkbox_);
 
   layout->StartRow(0, SINGLE_LINK_WITH_SHIFT_ROW);
   learn_more_link_ = new views::Link();
   learn_more_link_->SetController(this);
   layout->AddView(learn_more_link_);
 
   layout->AddPaddingRow(0, kRelatedControlSmallVerticalSpacing);
   layout->StartRow(0, SINGLE_CONTROL_ROW);
   oem_eula_label_ = new views::Label(std::wstring(), label_font);
@@ skipping 68 matching lines @@
   UpdateLocalizedStrings();
   Layout();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // views::ButtonListener implementation:
 
 void EulaView::ButtonPressed(views::Button* sender, const views::Event& event) {
   if (sender == continue_button_) {
     if (usage_statistics_checkbox_) {
-      GoogleUpdateSettings::SetCollectStatsConsent(
-        usage_statistics_checkbox_->checked());
+      const bool enable_reporting = usage_statistics_checkbox_->checked();
+      PrefService* prefs = g_browser_process->local_state();
+      if (prefs->GetBoolean(prefs::kMetricsReportingEnabled) !=
+          enable_reporting) {
+        prefs->SetBoolean(prefs::kMetricsReportingEnabled, enable_reporting);

[Mattias Nissler (ping if slow), 2010/08/05 07:57:12]

I'm not current on the plans for ChromeOS w.r.t. configuration policy. When
ChromeOS starts supporting it, you also need to make sure that you disable or
hide the checkbox if the admin has already taken the decision through policy and
then not write the preference, since that'll fail.

+        prefs->SavePersistentPrefs();
+        OptionsUtil::ResolveMetricsReportingEnabled(enable_reporting);
+#if defined(USE_LINUX_BREAKPAD)
+        if (enable_reporting)
+          InitCrashReporter();
+#endif
+      }
     }
     observer_->OnExit(ScreenObserver::EULA_ACCEPTED);
   }
   // TODO(glotov): handle cancel button.
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // views::LinkController implementation:
 
 void EulaView::LinkActivated(views::Link* source, int event_flags) {
@@ skipping 19 matching lines @@
                                       unsigned changed_flags) {
   if (changed_flags & TabContents::INVALIDATE_TITLE) {
     if (PublishTitleIfReady(contents, google_eula_view_, google_eula_label_) ||
         PublishTitleIfReady(contents, oem_eula_view_, oem_eula_label_)) {
       Layout();
     }
   }
 }
 
 }  // namespace chromeos