Issue 3069012: AutoFill: Temporarily remove a NOTREACHED until WK is fixed to not send in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3069012: AutoFill: Temporarily remove a NOTREACHED until WK is fixed to not send in (Closed)

Created:
10 years, 4 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit), dhollowa

CC:
chromium-reviews, darin-cc_chromium.org

Visibility:
Public.

Description

AutoFill: Temporarily remove a NOTREACHED until WK is fixed to not send in empty strings. BUG=50674 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54196

Patch Set 2 : Bug. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	webkit/glue/webkitclient_impl.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

http://codereview.chromium.org/3069012/diff/1/2 File webkit/glue/webkitclient_impl.cc (right): http://codereview.chromium.org/3069012/diff/1/2#newcode284 webkit/glue/webkitclient_impl.cc:284: // strings. Don't comment out a NOTREACHED without a ...

10 years, 4 months ago (2010-07-29 21:07:42 UTC) #2

James Hawkins

10 years, 4 months ago (2010-07-29 21:10:37 UTC) #4

http://codereview.chromium.org/3069012/diff/1/2
File webkit/glue/webkitclient_impl.cc (right):

http://codereview.chromium.org/3069012/diff/1/2#newcode284
webkit/glue/webkitclient_impl.cc:284: // strings.
On 2010/07/29 21:07:42, Avi wrote:
> Don't comment out a NOTREACHED without a reference to a bug that has you as
its
> owner.

Done.

Expand Messages | Collapse Messages

Issue 3069012: AutoFill: Temporarily remove a NOTREACHED until WK is fixed to not send in (Closed)

Description

Patch Set 1 #

Patch Set 2 : Bug. #

Messages