Issue 3069008: remove the chromeos include and reland

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3069008: remove the chromeos include and reland (Closed)

Created:
10 years, 4 months ago by sargrass

Modified:
9 years, 7 months ago

Reviewers:
csilv, stuartmorgan, Evan Martin

CC:
chromium-reviews, dhg, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

remove the chromeos include and reland BUG=48883 TEST=Exercise Personal Stuff page via --enabled-tabbed-options Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54056

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -24 lines)			Patch
M	chrome/browser/dom_ui/clear_browser_data_handler.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/options_ui.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/personal_options_handler.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/personal_options_handler.cc	View	3 chunks	+23 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/options.html	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options/personal_options.html	View	4 chunks	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/options/personal_options.js	View	3 chunks	+25 lines, -5 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	3 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

Evan Martin

10 years, 4 months ago (2010-07-28 23:06:08 UTC) #1

Please don't commit stuff until it has passed the try bots!  Every time you land
a broken change you cost literally an hour of coworker time.