Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 3069006: Fixing CSS and switching over to DOM properties for central_roster.html. (Closed)

Created:
10 years, 5 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org
Visibility:
Public.

Description

Fixing CSS and switching over to DOM properties for central_roster.html. BUG=none TEST=should work exactly the same Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53862

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/resources/chat_manager/central_roster.html View 1 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scherkus (not reviewing)
10 years, 5 months ago (2010-07-27 21:48:57 UTC) #1
seh
http://codereview.chromium.org/3069006/diff/1/2 File chrome/browser/resources/chat_manager/central_roster.html (right): http://codereview.chromium.org/3069006/diff/1/2#newcode23 chrome/browser/resources/chat_manager/central_roster.html:23: overflow: hidden; I believe overflow replaces both overflow-x and ...
10 years, 5 months ago (2010-07-27 21:52:39 UTC) #2
scherkus (not reviewing)
http://codereview.chromium.org/3069006/diff/1/2 File chrome/browser/resources/chat_manager/central_roster.html (right): http://codereview.chromium.org/3069006/diff/1/2#newcode23 chrome/browser/resources/chat_manager/central_roster.html:23: overflow: hidden; On 2010/07/27 21:52:39, seh wrote: > I ...
10 years, 5 months ago (2010-07-27 21:58:00 UTC) #3
arv (Not doing code reviews)
10 years, 5 months ago (2010-07-27 22:53:17 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698