Issue 3068010: Change a DCHECK to a DCHECK_LT so we can see the failing values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3068010: Change a DCHECK to a DCHECK_LT so we can see the failing values. (Closed)

Created:
10 years, 4 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
erikchen

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Change a DCHECK to a DCHECK_LT so we can see the failing values. This DCHECK sometimes fails on the bots; seeing the failing values may help us diagnose the problem. BUG=50556 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54069

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/time_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Evan Martin

since you commented on the bug, here's a trivial review

10 years, 4 months ago (2010-07-28 23:20:49 UTC) #1

erikchen

10 years, 4 months ago (2010-07-28 23:22:28 UTC) #2

On 2010/07/28 23:20:49, Evan Martin wrote:
> since you commented on the bug, here's a trivial review

LGTM