Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1643)

Issue 3068006: Suppress more chromeos Valgrind warnings... (Closed)

Created:
10 years, 5 months ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org
Visibility:
Public.

Description

Suppress more chromeos Valgrind warnings http://build.chromium.org/buildbot/memory/builders/Chromium%20OS%20UI%20(valgrind)(4)/builds/4053/steps/memory%20test:%20ui/logs/stdio Example of the report: Leak_DefinitelyLost 90 (24 direct, 66 indirect) bytes in 1 blocks are definitely lost in loss record 7,592 of 9,109 operator new(unsigned int) (sr/local/google/valgrind-for-chromium-client/valgrind/scripts/valgrind-memcheck/coregrind/m_replacemalloc/vg_replace_malloc.c:262) (anonymous namespace)::IdMaps::IdMaps() (chrome/browser/chromeos/input_method/input_method_util.cc:51) DefaultSingletonTraits<(anonymous namespace)::IdMaps>::New() (./base/singleton.h:23) Singleton<(anonymous namespace)::IdMaps, DefaultSingletonTraits<(anonymous namespace)::IdMaps>, (anonymous namespace)::IdMaps>::get() (./base/singleton.h:198) chromeos::input_method::GetInputMethodDisplayNameFromId(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (chrome/browser/chromeos/input_method/input_method_util.cc:487) LanguageOptionsHandler::GetInputMethodList() (chrome/browser/chromeos/dom_ui/language_options_handler.cc:73) LanguageOptionsHandler::GetLocalizedValues(DictionaryValue*) (chrome/browser/chromeos/dom_ui/language_options_handler.cc:57) OptionsUI::AddOptionsPageUIHandler(DictionaryValue*, OptionsPageUIHandler*) (chrome/browser/dom_ui/options_ui.cc:175) OptionsUI::OptionsUI(TabContents*) (chrome/browser/dom_ui/options_ui.cc:138) DOMUI* NewDOMUI<OptionsUI>(TabContents*, GURL const&) (chrome/browser/dom_ui/dom_ui_factory.cc:48) DOMUIFactory::CreateDOMUIForURL(TabContents*, GURL const&) (chrome/browser/dom_ui/dom_ui_factory.cc:174) TabContents::CreateDOMUIForRenderManager(GURL const&) (chrome/browser/tab_contents/tab_contents.cc:2964) RenderViewHostManager::UpdateRendererStateForNavigate(NavigationEntry const&) (chrome/browser/tab_contents/render_view_host_manager.cc:570) RenderViewHostManager::Navigate(NavigationEntry const&) (chrome/browser/tab_contents/render_view_host_manager.cc:76) TabContents::NavigateToPendingEntry(NavigationController::ReloadType) (chrome/browser/tab_contents/tab_contents.cc:782) NavigationController::NavigateToPendingEntry(NavigationController::ReloadType) (chrome/browser/tab_contents/navigation_controller.cc:1048) NavigationController::LoadEntry(NavigationEntry*) (chrome/browser/tab_contents/navigation_controller.cc:292) NavigationController::LoadURL(GURL const&, GURL const&, unsigned int) (chrome/browser/tab_contents/navigation_controller.cc:497) Browser::CreateTabContentsForURL(GURL const&, GURL const&, Profile*, unsigned int, bool, SiteInstance*) const (chrome/browser/browser.cc:2226) Browser::AddTabWithURL(GURL const&, GURL const&, unsigned int, int, int, SiteInstance*, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (chrome/browser/browser.cc:882) Browser::ShowSingletonTab(GURL const&) (chrome/browser/browser.cc:1030) Browser::ShowOptionsTab() (chrome/browser/browser.cc:1770) Browser::OpenOptionsDialog() (chrome/browser/browser.cc:1782) Browser::ExecuteCommandWithDisposition(int, WindowOpenDisposition) (chrome/browser/browser.cc:2100) Browser::ExecuteCommand(int) (chrome/browser/browser.cc:2154) AutomationProvider::ExecuteBrowserCommand(int, int, IPC::Message*) (chrome/browser/automation/automation_provider.cc:959) void DispatchToMethod<AutomationProvider, void (AutomationProvider::*)(int, int, IPC::Message*), int, int, IPC::Message&>(AutomationProvider*, void (AutomationProvider::*)(int, int, IPC::Message*), Tuple2<int, int> const&, Tuple1<IPC::Message&>*) (./base/tuple.h:684) bool IPC::MessageWithReply<Tuple2<int, int>, Tuple1<bool&> >::DispatchDelayReply<AutomationProvider, void (AutomationProvider::*)(int, int, IPC::Message*)>(IPC::Message const*, AutomationProvider*, void (AutomationProvider::*)(int, int, IPC::Message*)) (./ipc/ipc_message_utils.h:1269) AutomationProvider::OnMessageReceived(IPC::Message const&) (chrome/browser/automation/automation_provider.cc:371) IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) (ipc/ipc_channel_proxy.cc:206) BUG=48130 TBR=glider,oshima Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Timur Iskhodzhanov
10 years, 5 months ago (2010-07-27 10:50:41 UTC) #1
Alexander Potapenko
10 years, 5 months ago (2010-07-27 11:02:26 UTC) #2
On 2010/07/27 10:50:41, Timur Iskhodzhanov wrote:
> 

LGTM

Powered by Google App Engine
This is Rietveld 408576698