chrome_frame/chrome_launcher_unittest.cc - Issue 3068004: base/ header cleanup. Forward declaration instead of including.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome_frame/chrome_launcher_unittest.cc

Issue 3068004: base/ header cleanup. Forward declaration instead of including. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: chrome_launcher_unittest.cc Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/test/ui_test_utils.cc ('k') | chrome_frame/test/chrome_frame_test_utils.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

	6 #include "base/file_path.h"

6 #include "base/logging.h"	7 #include "base/logging.h"

7 #include "chrome/common/chrome_switches.h"	8 #include "chrome/common/chrome_switches.h"

8 #include "chrome_frame/chrome_launcher.h"	9 #include "chrome_frame/chrome_launcher.h"

9 #include "testing/gtest/include/gtest/gtest.h"	10 #include "testing/gtest/include/gtest/gtest.h"

10	11

11 TEST(ChromeLauncher, IsValidCommandLine) {	12 TEST(ChromeLauncher, IsValidCommandLine) {

12 CommandLine bad(FilePath(L"dummy.exe"));	13 CommandLine bad(FilePath(L"dummy.exe"));

13 bad.AppendSwitch(switches::kNoFirstRun); // in whitelist	14 bad.AppendSwitch(switches::kNoFirstRun); // in whitelist

14 bad.AppendSwitch("no-such-switch"); // does not exist	15 bad.AppendSwitch("no-such-switch"); // does not exist

15 bad.AppendSwitch(switches::kHomePage); // exists but not in whitelist	16 bad.AppendSwitch(switches::kHomePage); // exists but not in whitelist

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"chrome-frame"));	65 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"chrome-frame"));

65 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"-chrome-frame"));	66 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"-chrome-frame"));

66 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"---chrome-frame"));	67 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"---chrome-frame"));

67 EXPECT_FALSE(chrome_launcher::IsValidArgument(L" --chrome-frame"));	68 EXPECT_FALSE(chrome_launcher::IsValidArgument(L" --chrome-frame"));

68 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-framefoobar"));	69 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-framefoobar"));

69 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"foobar--chrome-frame"));	70 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"foobar--chrome-frame"));

70 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-frames"));	71 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-frames"));

71 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--Chrome-frame"));	72 EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--Chrome-frame"));

72 EXPECT_FALSE(chrome_launcher::IsValidArgument(L""));	73 EXPECT_FALSE(chrome_launcher::IsValidArgument(L""));

73 }	74 }

OLD	NEW