Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 3067034: Revert 55072 - Revert 55063 - WebKit roll: 64705:64742.... (Closed)

Created:
10 years, 4 months ago by dhollowa
Modified:
9 years, 7 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 55072 - Revert 55063 - WebKit roll: 64705:64742. TBR=jianli Reverting this roll didn't seem to affect the test failures. So am reverting the revert. Mac 10.6 Bot were failing after this change in unit_tests and interactive_ui_tests. Failures seen: Failing tests: BrowserFocusTest.ClickingMovesFocus BrowserFocusTest.TabsRememberFocus BrowserFocusTest.FAILS_TabsRememberFocusFindInPage BrowserFocusTest.BackgroundBrowserDontStealFocus BrowserFocusTest.FAILS_FocusTraversal BrowserFocusTest.FAILS_FocusTraversalOnInterstitial BrowserFocusTest.FindFocusTest BrowserKeyEventsTest.CommandKeyEvents BrowserKeyEventsTest.FLAKY_ReservedAccelerators MouseLeaveTest.FAILS_TestOnMouseOut Note: Google Test filter = BrowserFocusTest.ClickingMovesFocus [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from BrowserFocusTest [ RUN ] BrowserFocusTest.ClickingMovesFocus ... /b/slave/chromium-dbg-mac-builder/build/src/chrome/../chrome/browser/browser_focus_uitest.cc:182: Failure Value of: IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW) Actual: false Expected: true and [----------] 2 tests from BrowserWindowFullScreenControllerTest [ RUN ] BrowserWindowFullScreenControllerTest.TestFullscreen [ OK ] BrowserWindowFullScreenControllerTest.TestFullscreen (375 ms) [ RUN ] BrowserWindowFullScreenControllerTest.TestActivate /b/slave/chromium-dbg-mac-builder/build/src/chrome/browser/cocoa/browser_window_controller_unittest.mm:600: Failure Value of: [controller_ createFullscreenWindow] Actual: 0xa9a4890 Expected: frontmostWindow Which is: 0x1e256e60 [ FAILED ] BrowserWindowFullScreenControllerTest.TestActivate (63 ms) [----------] 2 tests from BrowserWindowFullScreenControllerTest (438 ms total) Review URL: http://codereview.chromium.org/3072024 TBR=pfeldman@chromium.org Review URL: http://codereview.chromium.org/3051035 TBR=dhollowa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
dhollowa
10 years, 4 months ago (2010-08-05 17:05:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698