Issue 3067029: AutoFill: Add more NameField tests and fix incorrect logic in ParseEmpty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3067029: AutoFill: Add more NameField tests and fix incorrect logic in ParseEmpty. (Closed)

Created:
10 years, 4 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Visibility:
Public.

Description

AutoFill: Add more NameField tests and fix incorrect logic in ParseEmpty. ParseEmpty should only match against the label text. BUG=none TEST=NameFieldTest.*;AddressFieldTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54974

Patch Set 1 #

Patch Set 2 : Remove bad test. #

Patch Set 3 : Fix test. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+201 lines, -5 lines)			Patch
M	chrome/browser/autofill/address_field_unittest.cc	View	2	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/autofill/form_field.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autofill/name_field_unittest.cc	View		1 chunk	+198 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages