Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 3067026: Initial port of accelerated compositor to Mac OS X 10.6. Reused... (Closed)

Created:
10 years, 4 months ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, apatrick_chromium, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, dglazkov, stuartmorgan
Visibility:
Public.

Description

Initial port of accelerated compositor to Mac OS X 10.6. Reused infrastructure added for Pepper 3D and Core Animation plugins to render the compositor's output. The implementation allocates a fake "plugin window handle" on the browser side which is the "root" handle, containing the compositor's output, and which, if present, is drawn before any other accelerated plugin instances. Added messages from GPU process to browser process for handling window resizing and presentation of output. Added support to GGL for "view" contexts on Mac OS X, used only for the accelerated compositor, and requiring explicit resize notifications. The remainder of this port will go into the WebKit repository under https://bugs.webkit.org/show_bug.cgi?id=43398 after this for dependency reasons. Tested manually with CSS 3D and WebGL demos. Several stability and correctness issues remain and will be addressed in following CLs; however, the current code works for the majority of basic use cases including switching between accelerated compositing on and off, and scrolling of content. BUG=38969 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54923

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 38

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -46 lines) Patch
M chrome/browser/gpu_process_host.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/gpu_process_host.cc View 1 2 3 chunks +37 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h View 1 2 3 chunks +20 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc View 1 2 3 chunks +37 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 5 chunks +25 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.h View 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/test/test_render_view_host.cc View 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/gpu_messages.h View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M chrome/common/gpu_messages_internal.h View 1 2 4 chunks +30 lines, -3 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
chrome/gpu/gpu_channel.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/gpu/gpu_channel.cc View 1 2 4 chunks +12 lines, -2 lines 0 comments Download
M chrome/gpu/gpu_command_buffer_stub.h View 1 2 3 chunks +13 lines, -1 line 0 comments Download
M chrome/gpu/gpu_command_buffer_stub.cc View 1 2 5 chunks +52 lines, -2 lines 0 comments Download
M chrome/renderer/ggl/ggl.h View 1 2 1 chunk +23 lines, -1 line 0 comments Download
M chrome/renderer/ggl/ggl.cc View 1 2 6 chunks +33 lines, -6 lines 0 comments Download
M chrome/renderer/gpu_channel_host.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/gpu_channel_host.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/webgles2context_impl.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/webgles2context_impl.cc View 1 2 2 chunks +16 lines, -2 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_processor_mac.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
10 years, 4 months ago (2010-08-03 02:47:24 UTC) #1
pink (ping after 24hrs)
drive-by review. http://codereview.chromium.org/3067026/diff/25001/26002 File chrome/browser/gpu_process_host.h (right): http://codereview.chromium.org/3067026/diff/25001/26002#newcode16 chrome/browser/gpu_process_host.h:16: #include "chrome/common/gpu_messages.h" can you forward-declare the needed ...
10 years, 4 months ago (2010-08-03 16:51:47 UTC) #2
apatrick
http://codereview.chromium.org/3067026/diff/25001/26001 File chrome/browser/gpu_process_host.cc (right): http://codereview.chromium.org/3067026/diff/25001/26001#newcode170 chrome/browser/gpu_process_host.cc:170: #endif nit: #elif http://codereview.chromium.org/3067026/diff/25001/26001#newcode206 chrome/browser/gpu_process_host.cc:206: #endif nit: #elif http://codereview.chromium.org/3067026/diff/25001/26002 ...
10 years, 4 months ago (2010-08-03 17:35:32 UTC) #3
Ken Russell (switch to Gerrit)
http://codereview.chromium.org/3067026/diff/25001/26001 File chrome/browser/gpu_process_host.cc (right): http://codereview.chromium.org/3067026/diff/25001/26001#newcode170 chrome/browser/gpu_process_host.cc:170: #endif On 2010/08/03 17:35:32, apatrick wrote: > nit: #elif ...
10 years, 4 months ago (2010-08-04 00:24:36 UTC) #4
apatrick
10 years, 4 months ago (2010-08-04 01:23:47 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698