AutoFill suggestions for billing and credit card fields should show derived labels.

AutoFill suggestions for billing and credit card fields should show derived labels.

Changes suggestions for forms with billing information to show derived labels based on contents of suggestions, not the labels stored in the matched profiles.  Also, the suggestion logic has been updated to properly take account of the billing "relation" in the credit card info.  Credit card only suggestions now use derived labels as well.

BUG=50261
TEST=AutoFillManagerTest.GetBillingSuggestionsAddress1, AutoFillManagerTest.GetCreditCardSuggestions*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54147

[James Hawkins, 2010-07-28 23:45:54]

http://codereview.chromium.org/3067016/diff/1/2
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3067016/diff/1/2#newcode50
chrome/browser/autofill/autofill_manager.cc:50: return kCreditCardLabelPrefix +
cc->LastFourDigits();
Should probably remove 'Label' from this var name, as it's misleading.

http://codereview.chromium.org/3067016/diff/1/3
File chrome/browser/autofill/autofill_manager_unittest.cc (right):

http://codereview.chromium.org/3067016/diff/1/3#newcode94
chrome/browser/autofill/autofill_manager_unittest.cc:94: "2014", "Work");
What's the point of this change?

[dhollowa, 2010-07-28 23:52:46]

http://codereview.chromium.org/3067016/diff/1/3
File chrome/browser/autofill/autofill_manager_unittest.cc (right):

http://codereview.chromium.org/3067016/diff/1/3#newcode94
chrome/browser/autofill/autofill_manager_unittest.cc:94: "2014", "Work");
On 2010/07/28 23:45:54, James Hawkins wrote:
> What's the point of this change?

This increases coverage from "1" to "many" for the GetBillingSuggestionsAddress1
test.  It does not affect the other tests.

[dhollowa, 2010-07-28 23:53:20]

http://codereview.chromium.org/3067016/diff/1/2
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/3067016/diff/1/2#newcode50
chrome/browser/autofill/autofill_manager.cc:50: return kCreditCardLabelPrefix +
cc->LastFourDigits();
On 2010/07/28 23:45:54, James Hawkins wrote:
> Should probably remove 'Label' from this var name, as it's misleading.

Done.

[James Hawkins, 2010-07-28 23:55:28]

LGTM, assuming the tests get fixed at some point.