Issue 3067015: sync-webkit-git: more windows fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3067015: sync-webkit-git: more windows fixes (Closed)

Created:
10 years, 4 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews, pam+watch_chromium.org

Visibility:
Public.

Description

sync-webkit-git: more windows fixes We must pass shell=True on Windows for all subprocess module functions to get PATH expansion for finding git. This is commented in the first call to a subprocess function, so don't duplicate that comment elsewhere. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54072

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	tools/sync-webkit-git.py	View		4 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM. Should we make a wrapper function for subprocess.check_call?

10 years, 4 months ago (2010-07-28 22:45:48 UTC) #2

Evan Martin

10 years, 4 months ago (2010-07-28 23:04:17 UTC) #3

On 2010/07/28 22:45:48, tony wrote:
> LGTM.  Should we make a wrapper function for subprocess.check_call?

I considered it, but then I also use subprocess.call() in one place so that
would also need a wrapper.  sadness.

Expand Messages | Collapse Messages