Issue 3067013: posix: print error message when mkdtemp fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3067013: posix: print error message when mkdtemp fails. (Closed)

Created:
10 years, 4 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
brettw, Nico

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

posix: print error message when mkdtemp fails. Failure seen on the buildbots. It would help to know why. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54016

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	base/file_util_posix.cc	View		1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

lg http://codereview.chromium.org/3067013/diff/1/2 File base/file_util_posix.cc (right): http://codereview.chromium.org/3067013/diff/1/2#newcode424 base/file_util_posix.cc:424: DPLOG(ERROR) << "mkdtemp"; << errno? or does DPLOG ...

10 years, 4 months ago (2010-07-28 20:57:52 UTC) #2

Evan Martin

10 years, 4 months ago (2010-07-28 20:58:41 UTC) #3

the *PLOG family of loggers try to log errno in a thread-safe manner

Expand Messages | Collapse Messages