Issue 3067008: Touch extracted D3DX9 dll in extract_d3dx9 action....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3067008: Touch extracted D3DX9 dll in extract_d3dx9 action.... (Closed)

Created:
10 years, 5 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Touch extracted D3DX9 dll in extract_d3dx9 action. This was necessary because the Windows expand utility preserves the modification time from the archive. This lead to the extract_d3dx9 action firing repeatedly because the action output was older than the input. TEST=try BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54058

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -2 lines)			Patch
	A	build/extract_from_cab.py	View		1 chunk	+29 lines, -0 lines	2 comments	Download
	M	chrome/chrome.gyp	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

This is pretty grim. I'm open to suggestions for better ways to do it. Thanks.

10 years, 5 months ago (2010-07-28 02:25:58 UTC) #1

bradn

10 years, 4 months ago (2010-07-28 18:07:01 UTC) #2

Eh.. not ideal, but well LGTM

http://codereview.chromium.org/3067008/diff/2001/3001
File build/extract_from_cab.py (right):

http://codereview.chromium.org/3067008/diff/2001/3001#newcode13
build/extract_from_cab.py:13: print "Usage: extract_from_cab.py cab_path
archived_file output_dir"
Style guide says use consistent " or ' throughout.

http://codereview.chromium.org/3067008/diff/2001/3001#newcode29
build/extract_from_cab.py:29: sys.exit(0)
It defaults to this, so you can drop it.

Expand Messages | Collapse Messages