Issue 3067006: Add Mozc (Japanese IME) configuration DOM UI skeleton.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3067006: Add Mozc (Japanese IME) configuration DOM UI skeleton. (Closed)

Created:
10 years, 5 months ago by kochi

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, dhg, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org, satorux1, mazda, Yusuke Sato

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Add Mozc (Japanese IME) configuration DOM UI skeleton. This only includes boolean settings in the dialog. I will fill in other stuff in later CLs. BUG=chromium-os:4809 TEST=manually check on the netbook by uncommenting TODO lines. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53881

Patch Set 1 #

Patch Set 2 : Add options.html (comment only). #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+144 lines, -2 lines)			Patch
A	chrome/browser/chromeos/dom_ui/language_mozc_options_handler.h	View	1 chunk	+26 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/dom_ui/language_mozc_options_handler.cc	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/core_options_handler.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/options_ui.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options.html	View	2 chunks	+9 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/options/chromeos_language_mozc_options.html	View	1 chunk	+71 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kochi

Hi Erik, This is a CL for intorducing Mozc (Japanese IME) configuration DOM UI. This ...

10 years, 5 months ago (2010-07-27 06:40:30 UTC) #1

arv (Not doing code reviews)

LGTM Can you fix the description? It should say TEST=Manually ...

10 years, 5 months ago (2010-07-27 18:28:24 UTC) #2

kochi

10 years, 5 months ago (2010-07-27 23:59:22 UTC) #3

Thanks for your review.
Updated the description.

On 2010/07/27 18:28:24, arv wrote:
> LGTM
> 
> Can you fix the description? It should say TEST=Manually ...

Expand Messages | Collapse Messages