Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 3066044: Generalize virtually dispatched scavenger to virtually dispatched specialized visitors. (Closed)

Created:
10 years, 4 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Generalize virtually dispatched scavenger to virtually dispatched specialized visitors. Committed: http://code.google.com/p/v8/source/detail?r=5246

Patch Set 1 #

Total comments: 13

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1204 lines, -512 lines) Patch
M src/SConscript View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +23 lines, -0 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/factory.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/heap.cc View 1 9 chunks +192 lines, -260 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +24 lines, -0 lines 0 comments Download
M src/mark-compact.h View 3 chunks +7 lines, -3 lines 0 comments Download
M src/mark-compact.cc View 1 23 chunks +183 lines, -64 lines 0 comments Download
M src/objects.h View 1 22 chunks +107 lines, -24 lines 0 comments Download
M src/objects.cc View 1 15 chunks +13 lines, -95 lines 0 comments Download
M src/objects-inl.h View 4 chunks +70 lines, -21 lines 0 comments Download
A src/objects-visiting.h View 1 chunk +377 lines, -0 lines 0 comments Download
A src/objects-visiting.cc View 1 chunk +139 lines, -0 lines 0 comments Download
M src/serialize.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +23 lines, -0 lines 0 comments Download
M tools/gc-nvp-trace-processor.py View 2 chunks +39 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
LGTM http://codereview.chromium.org/3066044/diff/1/2 File SConstruct (right): http://codereview.chromium.org/3066044/diff/1/2#newcode152 SConstruct:152: '-g'], Noooo! http://codereview.chromium.org/3066044/diff/1/8 File src/heap.cc (right): http://codereview.chromium.org/3066044/diff/1/8#newcode1097 src/heap.cc:1097: ...
10 years, 4 months ago (2010-08-11 08:53:54 UTC) #1
Vyacheslav Egorov (Chromium)
10 years, 4 months ago (2010-08-11 11:16:25 UTC) #2
Erik, 

I did a minor refactoring in objects-visiting.h related to VisitorId
specializations. Please take look. 

[Unfortunately diff is not available due to file renaming].

Powered by Google App Engine
This is Rietveld 408576698