Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 3066034: Add a script to generate builds signed using the official keys. (Closed)

Created:
10 years, 4 months ago by gauravsh
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Add a script to generate builds signed using the official keys. The script sign_official_build.sh does the appropriate signing depending on whether an ssd, recovery or factory-install image is desired. Also re-factors some common functionality into common.sh. BUG=3496 TEST=manual I haven't had a chance to test this on an actual machine running our firmware but will do that before I actually check-in. Thoughts I'd atleast get this out to get the review going.

Patch Set 1 #

Total comments: 22

Patch Set 2 : review fixes #

Total comments: 2

Patch Set 3 : simplify script_dir logic #

Total comments: 2

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -16 lines) Patch
A scripts/image_signing/common.sh View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
A + scripts/image_signing/customize_image.sh View 1 3 chunks +5 lines, -16 lines 0 comments Download
A scripts/image_signing/sign_official_build.sh View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gauravsh
I will add the hooks to customize the rootfs with a later CL.
10 years, 4 months ago (2010-08-04 01:43:47 UTC) #1
petkov
Bunch of comments -- I hate shell scripts so I may be wrong :-) Also, ...
10 years, 4 months ago (2010-08-04 04:56:11 UTC) #2
petkov
Now that I finally read the bash man-page... http://codereview.chromium.org/3066034/diff/1/4 File scripts/image_signing/sign_official_build.sh (right): http://codereview.chromium.org/3066034/diff/1/4#newcode55 scripts/image_signing/sign_official_build.sh:55: trap ...
10 years, 4 months ago (2010-08-04 17:48:40 UTC) #3
gauravsh
http://codereview.chromium.org/3066034/diff/1/2 File scripts/image_signing/common.sh (right): http://codereview.chromium.org/3066034/diff/1/2#newcode8 scripts/image_signing/common.sh:8: if [[ $0 == '/'* ]]; On 2010/08/04 04:56:11, ...
10 years, 4 months ago (2010-08-04 18:33:43 UTC) #4
petkov
I still don't like the SCRIPT_DIR logic in common.sh... LGTM (although I'd rather you fix ...
10 years, 4 months ago (2010-08-04 19:32:57 UTC) #5
gauravsh
On Wed, Aug 4, 2010 at 12:32 PM, <petkov@chromium.org> wrote: > I still don't like ...
10 years, 4 months ago (2010-08-04 21:43:56 UTC) #6
petkov
thanks, still lgtm http://codereview.chromium.org/3066034/diff/11001/12003 File scripts/image_signing/sign_official_build.sh (right): http://codereview.chromium.org/3066034/diff/11001/12003#newcode90 scripts/image_signing/sign_official_build.sh:90: remove trailing blank lines
10 years, 4 months ago (2010-08-04 21:54:16 UTC) #7
Randall Spangler
LGTM http://codereview.chromium.org/3066034/diff/11001/12003 File scripts/image_signing/sign_official_build.sh (right): http://codereview.chromium.org/3066034/diff/11001/12003#newcode68 scripts/image_signing/sign_official_build.sh:68: echo "Output signed recovery image to ${OUTPUT_IMAGE}" Minor ...
10 years, 4 months ago (2010-08-04 22:13:54 UTC) #8
gauravsh
10 years, 4 months ago (2010-08-04 22:21:14 UTC) #9
Addressed comments, tested and pushed. Thanks!

Powered by Google App Engine
This is Rietveld 408576698