Don't delete npapi plugins copied into <(PRODUCT_DIR)/plugins

Don't delete npapi plugins copied into <(PRODUCT_DIR)/plugins
during UI tests.

The layout test plugin is copied over via a build step and needed
when running the layout tests.  If you run the UI tests before
the layout tests, the npapi layout test plugin is deleted and
causes layout tests to fail.  Seems like it's safe to keep the plugins
even after the UI tests end.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54965

[stuartmorgan, 2010-08-04 01:00:18]

You should be able to remove the entire class, since there's nothing left in it
after the Mac logic is removed. The other change doesn't seem right though,
since now it's copying it in but not removing it; if the build step is doing
that already, then both the copy and the removal should go.

(The Mac should be good though; at the time I added the TODO I thought this
class was used for more types of tests, not all of which have been updated to
use the new location.)

[tony, 2010-08-04 17:29:45]

On 2010/08/04 01:00:18, stuartmorgan wrote:
> You should be able to remove the entire class, since there's nothing left in
it
> after the Mac logic is removed.

The class is needed because the base class can't be used with the TEST_F macro. 
The base class requires an argument (the plugin name), so we need an
implementation class for testing.


> The other change doesn't seem right though,
> since now it's copying it in but not removing it; if the build step is doing
> that already, then both the copy and the removal should go.

We use this code for npapi_layout_test_plugin.dll and
npapi_pepper_test_plugin.dll.  npapi_layout_test_plugin.dll is copied by a build
step, npapi_pepper_test_plugin.dll isn't.  I would like to fix that in a follow
up step (and delete this copy code), but I'm trying to make a sufficiently small
patch that I can merge to the 472 branch to make the official builders go green.
 In that vein, I've uploaded a new patch with just the DieFileDie command
removed.

[stuartmorgan, 2010-08-04 17:51:16]

LGTM, but please add a TODO for removing the copy step.