Issue 3066018: Roll over again fixed 3029033 Fix 'step in' after live edit stack manipulation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3066018: Roll over again fixed 3029033 Fix 'step in' after live edit stack manipulation (Closed)

Created:
10 years, 4 months ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Roll over again fixed 3029033 Fix 'step in' after live edit stack manipulation Committed: http://code.google.com/p/v8/source/detail?r=5160

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -45 lines)			Patch
M	src/arm/debug-arm.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/debug.h	View	6 chunks	+32 lines, -3 lines	0 comments	Download
M	src/debug.cc	View	4 chunks	+48 lines, -30 lines	0 comments	Download
M	src/debug-debugger.js	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/ia32/debug-ia32.cc	View	3 chunks	+11 lines, -2 lines	0 comments	Download
M	src/liveedit.cc	View	4 chunks	+11 lines, -4 lines	0 comments	Download
M	src/mips/debug-mips.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/serialize.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/x64/debug-x64.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Peter Rybin

Hi Soren This is a regular non-TBR change. It's absolutely the same with unsuccessful http://codereview.chromium.org/3029033 ...

10 years, 4 months ago (2010-07-29 21:54:27 UTC) #1

LGTM