Test to verify the 'multiple downloads' infobar

Test to verify the 'multiple downloads' infobar

Verifies the multiple downloads infobar.

Implemented by Venkat, who figured out how to reliably trigger the multiple
downloads infobar.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54163

[John Grabowski, 2010-07-29 18:49:56]

LGTM

http://codereview.chromium.org/3066017/diff/2001/3002
File chrome/test/functional/infobars.py (right):

http://codereview.chromium.org/3066017/diff/2001/3002#newcode128
chrome/test/functional/infobars.py:128: self.assertTrue(infobars, 'Expected the
multiple downloads infobar')
Wrap english text for buttons and match_text inside some conditional which
confirms we have US locality.  (That's just 3 lines here.)  That is_enus()
routine can return true for now but will help ease the transition if/when we try
to run PyAuto with a Krom or !Khrohmz.

[Nirnimesh, 2010-07-29 19:14:23]

http://codereview.chromium.org/3066017/diff/2001/3002
File chrome/test/functional/infobars.py (right):

http://codereview.chromium.org/3066017/diff/2001/3002#newcode128
chrome/test/functional/infobars.py:128: self.assertTrue(infobars, 'Expected the
multiple downloads infobar')
On 2010/07/29 18:49:57, John Grabowski wrote:
> Wrap english text for buttons and match_text inside some conditional which
> confirms we have US locality.  (That's just 3 lines here.)  That is_enus()
> routine can return true for now but will help ease the transition if/when we
try
> to run PyAuto with a Krom or !Khrohmz.
> 

Done.

[John Grabowski, 2010-07-29 19:48:55]

http://codereview.chromium.org/3066017/diff/7001/8002
File chrome/test/functional/infobars.py (right):

http://codereview.chromium.org/3066017/diff/7001/8002#newcode113
chrome/test/functional/infobars.py:113: assert pyauto.PyUITest.IsEnUS()
What I meant was:

...
if pyauto.PyUITest.IsEnUS():
  self.assertEqual(match_text, infobars[0]['text'])
  self.assertEqual('Allow', infobars[0]['buttons'][0])
  self.assertEqual('Deny', infobars[0]['buttons'][1])
else:
  # log warning about part of test being disabled

[Nirnimesh, 2010-07-29 20:02:21]

(sorry I had committed. will recommit after this fix)

http://codereview.chromium.org/3066017/diff/7001/8002
File chrome/test/functional/infobars.py (right):

http://codereview.chromium.org/3066017/diff/7001/8002#newcode113
chrome/test/functional/infobars.py:113: assert pyauto.PyUITest.IsEnUS()
On 2010/07/29 19:48:55, John Grabowski wrote:
> What I meant was:
> 
> ...
> if pyauto.PyUITest.IsEnUS():
>   self.assertEqual(match_text, infobars[0]['text'])
>   self.assertEqual('Allow', infobars[0]['buttons'][0])
>   self.assertEqual('Deny', infobars[0]['buttons'][1])
> else:
>   # log warning about part of test being disabled
> 

Done.