Issue 3066015: Disable run-time flag for device orientation in test_shell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3066015: Disable run-time flag for device orientation in test_shell (Closed)

Created:
10 years, 4 months ago by hans

Modified:
9 years, 5 months ago

Reviewers:
jorlow

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Visibility:
Public.

Description

Disable run-time flag for device orientation in test_shell Device orientation runtime flag must be switched off in test_shell, as it doesn't provide a DeviceOrientationClient to the Page constructor. WebKit r64270 triggered the problem by using this NULL client in the DeviceOrientationController constructor, causing it to crash. The DeviceOrientationController does not get instantiated when the runtime flag is off. BUG=None TEST=test_shell should not crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54125

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	webkit/tools/test_shell/test_shell_webkit_init.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

jorlow

10 years, 4 months ago (2010-07-29 13:05:48 UTC) #1

LGTM

Maybe add a TODO(hans): to change this back once enough is implemented on the
Chromium side.

Expand Messages | Collapse Messages