Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3066014: Cleanup: Remove unneeded headers from app/ (part 2) (Closed)

Created:
10 years, 4 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Paul Godavari, jam, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Cleanup: Remove unneeded headers from app/ (part 2) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54437

Patch Set 1 : '' #

Patch Set 2 : fix win #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -98 lines) Patch
M chrome/browser/autofill/autofill_cc_infobar_win.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/browser_main_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/input_window_dialog_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/shell_integration_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/app_launcher.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/appcache_info_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_instructions_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/bookmark_bubble_view.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/bookmark_context_menu_controller_views.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/bookmark_menu_controller_views.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/browser_bubble.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/browser_bubble_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/constrained_window_win.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/views/database_open_info_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/download_item_view.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/views/find_bar_host.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/find_bar_host.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/frame/browser_frame_win.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/views/frame/opaque_browser_frame_view.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
MM chrome/browser/views/infobars/after_translate_infobar.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/views/infobars/after_translate_infobar.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/views/infobars/before_translate_infobar.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/infobars/before_translate_infobar.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/infobars/infobar_button_border.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/keyword_editor_view.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/notifications/balloon_view.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/options/advanced_contents_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/options/content_page_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/options/content_settings_window_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/options/cookies_view.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/views/options/fonts_languages_window_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/options/fonts_page_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/options_window_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/shell_dialogs_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/status_bubble_views.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/tab_contents/render_view_context_menu_views.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/tab_contents/render_view_context_menu_views.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/base_tab.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/side_tab.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/side_tab.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/url_picker.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/nacl/nacl_main.cc View 1 2 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/plugin/plugin_main.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/renderer/print_web_view_helper_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/renderer_main.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M printing/printed_document_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/controls/button/native_button.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/controls/combobox/native_combobox_win.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M views/controls/label.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M views/controls/listbox/native_listbox_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/controls/menu/menu_2.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/controls/menu/menu_item_view_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/controls/progress_bar.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M views/controls/progress_bar_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/controls/scroll_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/controls/tabbed_pane/native_tabbed_pane_gtk.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/controls/tree/tree_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/drag_utils.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/focus/focus_manager_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/widget/tooltip_manager_win.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/window/custom_frame_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/window/non_client_view.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M views/window/window_gtk.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M views/window/window_win.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
10 years, 4 months ago (2010-07-29 17:42:29 UTC) #1
Elliot Glaysher
10 years, 4 months ago (2010-07-29 17:56:33 UTC) #2 
LGTM.

Side note: I accidently broke the official builders the other day with one of
these patches. You may want to watch those bots, too.

Powered by Google App Engine
This is Rietveld 408576698