Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 3066012: Remove PulseAudio 48553 suppression (Closed)

Created:
10 years, 4 months ago by davejcool
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko
Base URL:
git://codf21.jail.google.com/chromium.git
Visibility:
Public.

Description

Remove PulseAudio 48553 suppression The memory leaks do not happen if connecting to PulseAudio on the calling (UI) thread at browser init time. Since this change is checked in (r53992), this suppression can be removed. BUG=48553 TEST=There should be no more PulseAudio related memory leaks or assertion failures. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
davejcool
Valgrind (2) and (4) have caught up to build r53992, and are no longer showing ...
10 years, 4 months ago (2010-07-29 00:03:50 UTC) #1
scherkus (not reviewing)
LGTM assuming bots are all good
10 years, 4 months ago (2010-07-29 00:05:29 UTC) #2
scherkus (not reviewing)
10 years, 4 months ago (2010-07-29 00:05:29 UTC) #3
LGTM assuming bots are all good

Powered by Google App Engine
This is Rietveld 408576698