Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 3066011: ffmpeg configured with webm decode only to avoid postproc that pulls in unuse... (Closed)

Created:
10 years, 4 months ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

ffmpeg configured with webm decode only to avoid postproc that pulls in unused data BUG=50507, 50533 TEST=xp perf should pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54042

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+553 lines, -529 lines) Patch
M README.chromium View 2 chunks +10 lines, -0 lines 1 comment Download
MM patches/to_upstream/01_static_pthread_O2.patch View 2 chunks +4 lines, -4 lines 0 comments Download
MM patches/to_upstream/02_mov_dref_looping.patch View 1 chunk +2 lines, -2 lines 0 comments Download
MM patches/to_upstream/03_mpeg4_video_to_elementary_stream.patch View 5 chunks +9 lines, -9 lines 0 comments Download
MM patches/to_upstream/04_vc1_bsfs.patch View 4 chunks +6 lines, -6 lines 0 comments Download
MM patches/to_upstream/05_respect_flac_dirac_configure.patch View 3 chunks +6 lines, -6 lines 0 comments Download
MM patches/to_upstream/06_remove_decode_on_config_no_svq3.patch View 1 chunk +2 lines, -2 lines 0 comments Download
MM patches/to_upstream/11_mkv_buffer_overflow.patch View 1 1 chunk +2 lines, -2 lines 0 comments Download
MM patches/to_upstream/12_ogg_seek_to_zero.patch View 1 1 chunk +2 lines, -2 lines 0 comments Download
A patches/to_upstream/13_libvpx_check_decoder_only.patch View 1 chunk +14 lines, -0 lines 0 comments Download
MM patches/ugly/07_get_bits_overrun.patch View 1 chunk +2 lines, -2 lines 0 comments Download
MM patches/ugly/08_enforce_theora_oob.patch View 1 chunk +2 lines, -2 lines 0 comments Download
MM patches/ugly/09_enforce_vorbis_oob_divzero.patch View 1 chunk +2 lines, -2 lines 0 comments Download
MM patches/ugly/10_aac_oob_read.patch View 1 chunk +2 lines, -2 lines 0 comments Download
MM patches/ugly/11_ogg_seek_first_frame.patch View 1 chunk +486 lines, -486 lines 0 comments Download
M source/patched-ffmpeg-mt/configure View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fbarchard
XP perf was catching a bug in libvpx The bug relates to encoding and post ...
10 years, 4 months ago (2010-07-28 22:21:59 UTC) #1
scherkus (not reviewing)
does this depend on checking in new libvpx libs? http://codereview.chromium.org/3066011/diff/3001/4001 File README.chromium (right): http://codereview.chromium.org/3066011/diff/3001/4001#newcode131 README.chromium:131: ...
10 years, 4 months ago (2010-07-28 22:45:37 UTC) #2
fbarchard
On 2010/07/28 22:45:37, scherkus wrote: > does this depend on checking in new libvpx libs? ...
10 years, 4 months ago (2010-07-28 23:01:15 UTC) #3
scherkus (not reviewing)
LGTM
10 years, 4 months ago (2010-07-28 23:06:54 UTC) #4
fgalligan
10 years, 4 months ago (2010-07-29 06:58:15 UTC) #5
The CL for removing the 1.6 MB global has been landed in libvpx
https://review.webmproject.org/#change,360



On Wed, Jul 28, 2010 at 7:01 PM, <fbarchard@chromium.org> wrote:

> On 2010/07/28 22:45:37, scherkus wrote:
>
>> does this depend on checking in new libvpx libs?
>>
>
> no new source, just reconfigured to --enable-vp8-decoder
>
>
>
>  http://codereview.chromium.org/3066011/diff/3001/4001
>> File README.chromium (right):
>>
>
>  http://codereview.chromium.org/3066011/diff/3001/4001#newcode131
>> README.chromium:131: rm -rf orig
>> we don't have to do this now, but perhaps we can provide a shell script
>> that
>> accomplishes this?
>>
>
>  there's a lot of duplicated commands here that could be remedied with a
>> bash
>> function :)
>>
>
> I used to have one, but once it ran amok and killed patches, so I dont
> trust it.
>  And its useful, when working on updates to a specific patch, to do all the
> patches up to the interesting one, and then apply just the steps for that
> one
> patch.
> I could move it out of the readme, but it has to stay in lock step with the
> patches.
> Also I'm finding the step is useful... we have clean patches, that stay
> closer
> to HEAD ffmpeg so they don't break as often.
>
>
>
> http://codereview.chromium.org/3066011/show
>

Powered by Google App Engine
This is Rietveld 408576698