Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: chrome/browser/cocoa/toolbar_controller.mm

Issue 3066009: Use a PDF for the upgrade dot.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/theme/upgrade_dot.pdf ('k') | chrome/chrome_dll.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/toolbar_controller.mm
===================================================================
--- chrome/browser/cocoa/toolbar_controller.mm (revision 53801)
+++ chrome/browser/cocoa/toolbar_controller.mm (working copy)
@@ -562,17 +562,10 @@
}
- (void)badgeWrenchMenu {
- // The wrench menu gets an upgrade dot. This gets ugly because we only have a
- // PNG so we need to position it. TODO(avi): Get a PDF version, one ready for
- // overlaying. http://crbug.com/49668
- //
// In the Windows version, the ball doesn't actually pulsate, and is always
// drawn with the inactive image. Why? (We follow suit, though not on the
// weird positioning they do that overlaps the button border.)
- ThemeProvider* theme_provider = profile_->GetThemeProvider();
- NSImage* badge = theme_provider->GetNSImageNamed(IDR_UPGRADE_DOT_INACTIVE,
- true);
-
+ NSImage* badge = nsimage_cache::ImageNamed(@"upgrade_dot.pdf");
NSImage* wrenchImage = nsimage_cache::ImageNamed(kWrenchButtonImageName);
NSSize wrenchImageSize = [wrenchImage size];
« no previous file with comments | « chrome/app/theme/upgrade_dot.pdf ('k') | chrome/chrome_dll.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698