Update the tsl2563 test.

Update the tsl2563 test.

Remove the unneeded C source.  Do everything in the test script.

Update the control file to correct documentation and use more standard strings.

BUG=chromium-os:1288
BUG=chromium-os:3094
TEST=manual

[petkov, 2010-08-05 21:22:38]

http://codereview.chromium.org/3064043/diff/1/2
File client/site_tests/hardware_tsl2563/control (right):

http://codereview.chromium.org/3064043/diff/1/2#newcode9
client/site_tests/hardware_tsl2563/control:9: Fails if the tsl2563 kernel module
is not loaded, or its sys files are not exported.
80 chars

http://codereview.chromium.org/3064043/diff/1/3
File client/site_tests/hardware_tsl2563/hardware_tsl2563.py (right):

http://codereview.chromium.org/3064043/diff/1/3#newcode5
client/site_tests/hardware_tsl2563/hardware_tsl2563.py:5: import os, logging
sort

http://codereview.chromium.org/3064043/diff/1/3#newcode23
client/site_tests/hardware_tsl2563/hardware_tsl2563.py:23: lux_out =
utils.system_output('cat /sys/class/iio/device0/lux')
You should probably use utils.read_one_line here

http://codereview.chromium.org/3064043/diff/1/3#newcode25
client/site_tests/hardware_tsl2563/hardware_tsl2563.py:25: raise
error.TestFail('The tsl2563 driver is not exporting its lux file')
80 chars

http://codereview.chromium.org/3064043/diff/1/3#newcode28
client/site_tests/hardware_tsl2563/hardware_tsl2563.py:28: raise
error.TestFail('Invalid tsl2563 lux string (%s)', lux_out)
Not sure if TestFail supports comma-separated arguments -- does this work?

I think you should use % instead.

[bfreed, 2010-08-06 18:03:01]

This should do it.

http://codereview.chromium.org/3064043/diff/1/2
File client/site_tests/hardware_tsl2563/control (right):

http://codereview.chromium.org/3064043/diff/1/2#newcode9
client/site_tests/hardware_tsl2563/control:9: Fails if the tsl2563 kernel module
is not loaded, or its sys files are not exported.
On 2010/08/05 21:22:38, petkov wrote:
> 80 chars
> 

Done.

http://codereview.chromium.org/3064043/diff/1/3
File client/site_tests/hardware_tsl2563/hardware_tsl2563.py (right):

http://codereview.chromium.org/3064043/diff/1/3#newcode5
client/site_tests/hardware_tsl2563/hardware_tsl2563.py:5: import os, logging
On 2010/08/05 21:22:38, petkov wrote:
> sort
> 

Done.

http://codereview.chromium.org/3064043/diff/1/3#newcode23
client/site_tests/hardware_tsl2563/hardware_tsl2563.py:23: lux_out =
utils.system_output('cat /sys/class/iio/device0/lux')
On 2010/08/05 21:22:38, petkov wrote:
> You should probably use utils.read_one_line here
> 

Done.

http://codereview.chromium.org/3064043/diff/1/3#newcode25
client/site_tests/hardware_tsl2563/hardware_tsl2563.py:25: raise
error.TestFail('The tsl2563 driver is not exporting its lux file')
On 2010/08/05 21:22:38, petkov wrote:
> 80 chars
> 

Done.

http://codereview.chromium.org/3064043/diff/1/3#newcode28
client/site_tests/hardware_tsl2563/hardware_tsl2563.py:28: raise
error.TestFail('Invalid tsl2563 lux string (%s)', lux_out)
On 2010/08/05 21:22:38, petkov wrote:
> Not sure if TestFail supports comma-separated arguments -- does this work?
> 
> I think you should use % instead.
> 

Done.

http://codereview.chromium.org/3064043/diff/5001/6002#newcode28
client/site_tests/hardware_tsl2563/hardware_tsl2563.py:28: raise
error.TestFail('Invalid tsl2563 lux string (%s)', lux_out)
Testing shows I can get values over 64K.  In looking at the code, there is no
discernible limit to what it reports.

[petkov-google, 2010-08-06 20:06:13]

LGTM

[petkov, 2010-08-06 20:08:28]

LGTM from the right account FWIW