Issue 3064011: Dump some unused strings to test .grd handling with the recent IncrediBuild update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3064011: Dump some unused strings to test .grd handling with the recent IncrediBuild update (Closed)

Created:
10 years, 5 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, TVL

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Dump some unused strings to test .grd handling with the recent IncrediBuild update. The strings being removed are all unused and were not added recently. BUG=none TEST=Ideally, this will not cause test failures on Windows. This change is actually the TEST= of a build tool upgrade. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53811

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	M	chrome/app/generated_resources.grd	View		3 chunks	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

I chose a string near the beginning, middle, and end of the file, and verified ...

10 years, 5 months ago (2010-07-27 18:09:55 UTC) #2

TVL

10 years, 5 months ago (2010-07-27 18:11:45 UTC) #3

lgtm (i guess trybots would also tell you if this worked, but they are pretty
backed up)

Expand Messages | Collapse Messages