Issue 3064010: Follow-up to r53769 - forgot to add a new file to the CL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3064010: Follow-up to r53769 - forgot to add a new file to the CL (Closed)

Created:
10 years, 5 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Alexander Potapenko, Timur Iskhodzhanov, cbentzel+watch_chromium.org, stuartmorgan, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Follow-up to r53769 - forgot to add a new file to the CL TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53771

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	A	net/data/valgrind/net_unittests.gtest-tsan.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 5 months ago (2010-07-27 11:56:38 UTC) #2

LG

On Tue, Jul 27, 2010 at 2:46 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Follow-up to r53769 - forgot to add a new file to the CL
> TBR=glider
>
> Please review this at http://codereview.chromium.org/3064010/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  A     net/data/valgrind/net_unittests.gtest-tsan.txt
>
>
> Index: net/data/valgrind/net_unittests.gtest-tsan.txt
> ===================================================================
> --- net/data/valgrind/net_unittests.gtest-tsan.txt      (revision 0)
> +++ net/data/valgrind/net_unittests.gtest-tsan.txt      (revision 0)
> @@ -0,0 +1,3 @@
> +# These huge tests are flaky and sometimes crash the following tests.
> +# See http://crbug.com/50346
> +DiskCacheEntryTest.*HugeSparse*
>
> Property changes on: net/data/valgrind/net_unittests.gtest-tsan.txt
> ___________________________________________________________________
> Added: svn:eol-style
>   + LF
>
>
>
>

Expand Messages | Collapse Messages