Issue 3064007: GTTF: more FRIEND_TEST_ALL_PREFIXES

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3064007: GTTF: more FRIEND_TEST_ALL_PREFIXES (Closed)

Created:
10 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, awong

CC:
chromium-reviews, scherkus (not reviewing), fbarchard, awong, Alpha Left Google

Visibility:
Public.

Description

GTTF: more FRIEND_TEST_ALL_PREFIXES TEST=compile BUG=44549 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53793

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -50 lines)			Patch
M	jingle/notifier/listener/talk_mediator_impl.h	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	media/audio/linux/alsa_output.h	View	2 chunks	+24 lines, -21 lines	0 comments	Download
M	media/base/pipeline_impl.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	media/filters/audio_renderer_algorithm_ola.h	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	media/filters/bitstream_converter.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer.h	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	media/filters/ffmpeg_video_decoder.h	View	2 chunks	+9 lines, -6 lines	0 comments	Download
M	media/filters/file_data_source.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awong

10 years, 4 months ago (2010-07-27 01:20:58 UTC) #2

LGTM.

On Mon, Jul 26, 2010 at 5:52 PM, <phajdan.jr@chromium.org> wrote:

> Reviewers: Lei Zhang, awong,
>
> Description:
> GTTF: more FRIEND_TEST_ALL_PREFIXES
>
> TEST=compile
> BUG=44549
>
> Please review this at http://codereview.chromium.org/3064007/show
>
> Affected files:
>  M jingle/notifier/listener/talk_mediator_impl.h
>  M media/audio/linux/alsa_output.h
>  M media/base/pipeline_impl.h
>  M media/filters/audio_renderer_algorithm_ola.h
>  M media/filters/bitstream_converter.h
>  M media/filters/ffmpeg_demuxer.h
>  M media/filters/ffmpeg_video_decoder.h
>  M media/filters/file_data_source.h
>
>
>

Expand Messages | Collapse Messages