Issue 3064006: Make the throbber and tab close button correctly respond to theme changes. T...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3064006: Make the throbber and tab close button correctly respond to theme changes. T... (Closed)

Created:
10 years, 5 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the throbber and tab close button correctly respond to theme changes. This is partly using GetThemeProvider() instead of ResourceBundle::GetSharedInstance(), and partly not caching SkBitmaps (which we used to do long ago but stopped because it's pointless). BUG=50107 TEST=Throbber responds to theme changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53740

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -138 lines)			Patch
M	chrome/browser/views/tab_icon_view.cc	View	7 chunks	+20 lines, -20 lines	0 comments	Download
M	chrome/browser/views/tabs/base_tab.h	View	3 chunks	+0 lines, -20 lines	0 comments	Download
M	chrome/browser/views/tabs/base_tab.cc	View	8 chunks	+47 lines, -92 lines	0 comments	Download
M	chrome/browser/views/tabs/tab.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages