Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: views/widget/widget_gtk.cc

Issue 3063025: [Linux views]Fix the return value of WidgetGtk::HandleKeyboardEvent(). (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/widget/widget_gtk.cc
diff --git a/views/widget/widget_gtk.cc b/views/widget/widget_gtk.cc
index 93fdcdc174aeb54fc7d4c3b9ac99ace5e5ff7a80..42aac381b5856caffa8a4cdde41458958751d1de 100644
--- a/views/widget/widget_gtk.cc
+++ b/views/widget/widget_gtk.cc
@@ -879,8 +879,9 @@ bool WidgetGtk::HandleKeyboardEvent(GdkEventKey* event) {
if (event->type == GDK_KEY_PRESS) {
// VKEY_MENU is triggered by key release event.
+ // FocusManager::OnKeyEvent() returns false when the key has been consumed.
if (key_code != base::VKEY_MENU)
- handled = focus_manager_->OnKeyEvent(key);
+ handled = !focus_manager_->OnKeyEvent(key);
else
should_handle_menu_key_release_ = true;
} else if (key_code == base::VKEY_MENU && should_handle_menu_key_release_ &&
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698