Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 3063018: o3djs: Make bump shader code compile for webgl. (Closed)

Created:
10 years, 4 months ago by Patrick Horn
Modified:
9 years, 7 months ago
Reviewers:
petersont, luchen
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

o3djs: Make bump shader code compile for webgl. BUG=none TEST=collada mesh with bumpUV enabled and using the lambert shader. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55001

Patch Set 1 #

Patch Set 2 : Fix output semantic so it compiles in o3d #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M o3d/samples/o3djs/effect.js View 1 3 chunks +23 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Patrick Horn
The collada mesh here uses bump/normal maps: http://inst.eecs.berkeley.edu/~pathorn/skinned_robot.zip A lot of the changes were things ...
10 years, 4 months ago (2010-08-03 02:23:14 UTC) #1
luchen
Do I need to convert the .zip to o3dtgz->json in order to load the model?
10 years, 4 months ago (2010-08-03 03:22:56 UTC) #2
Patrick Horn
On 2010/08/03 03:22:56, luchen wrote: > Do I need to convert the .zip to o3dtgz->json ...
10 years, 4 months ago (2010-08-03 04:12:54 UTC) #3
luchen
When I unzip the file I only see the .dae and four .tga. No scene.json. ...
10 years, 4 months ago (2010-08-03 16:44:20 UTC) #4
Patrick Horn
Try again--I had uploaded the original by accident. On 2010/08/03 16:44:20, luchen wrote: > When ...
10 years, 4 months ago (2010-08-03 20:32:24 UTC) #5
luchen
LGTM. On 2010/08/03 20:32:24, Patrick Horn wrote: > Try again--I had uploaded the original by ...
10 years, 4 months ago (2010-08-04 21:57:24 UTC) #6
Patrick Horn
10 years, 4 months ago (2010-08-04 23:53:48 UTC) #7
Fixed a mistake in the cg shader because I changed the output semantic names. I
did a comparison of the output programs before and after, and they are the same,
so I'm still going to commit.

However, my test mesh won't load in the o3d plugin before or after my change,
but because it has no TANGENT stream. Do you know of any scenes which use
bumpUV? The teapot doesn't seem to.

Powered by Google App Engine
This is Rietveld 408576698