Merge 53127 - Added checks to handle unsyncable extensions....

chrome/browser/sync/glue/extension_change_processor.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/extension_change_processor.h"
 
 #include <sstream>
 #include <string>
 
 #include "base/logging.h"
@@ skipping 33 matching lines @@
   DCHECK(running());
   DCHECK(profile_);
   switch (type.value) {
     case NotificationType::EXTENSION_LOADED:
     case NotificationType::EXTENSION_UPDATE_DISABLED:
     case NotificationType::EXTENSION_UNLOADED:
     case NotificationType::EXTENSION_UNLOADED_DISABLED: {
       DCHECK_EQ(Source<Profile>(source).ptr(), profile_);
       Extension* extension = Details<Extension>(details).ptr();
       CHECK(extension);
+      // Ignore non-syncable extensions.
       if (!IsExtensionSyncable(*extension)) {
         return;
       }
       const std::string& id = extension->id();
       LOG(INFO) << "Got change notification of type " << type.value
                 << " for extension " << id;
       if (!extension_model_associator_->OnClientUpdate(id)) {
         std::string error = std::string("Client update failed for ") + id;
         error_handler()->OnUnrecoverableError(FROM_HERE, error);
         return;
@@ skipping 100 matching lines @@
 }
 
 void ExtensionChangeProcessor::StopObserving() {
   DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
   DCHECK(profile_);
   LOG(INFO) << "Unobserving all notifications";
   notification_registrar_.RemoveAll();
 }
 
 }  // namespace browser_sync