New pyauto translate hooks: always and never translate button.

New pyauto translate hooks: always and never translate button.

This hooks allows testers to test that always and never translate button that shows up after a user has accepted/declined translation several times.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55590

[Alyssa, 2010-08-06 01:19:20]

This should round out all of the translation hooks that are currently supported
by the translate code.

[Paweł Hajdan Jr., 2010-08-06 17:54:17]

Drive-by with a test question.

http://codereview.chromium.org/3061054/diff/4001/8
File chrome/test/functional/translate.py (right):

http://codereview.chromium.org/3061054/diff/4001/8#newcode331
chrome/test/functional/translate.py:331: while not
self.GetTranslateInfo()['translate_bar']\
Why is this a loop?

[Alyssa, 2010-08-06 18:00:23]

On 2010/08/06 17:54:17, Paweł Hajdan Jr. wrote:
> Drive-by with a test question.
> 
> http://codereview.chromium.org/3061054/diff/4001/8
> File chrome/test/functional/translate.py (right):
> 
> http://codereview.chromium.org/3061054/diff/4001/8#newcode331
> chrome/test/functional/translate.py:331: while not
> self.GetTranslateInfo()['translate_bar']\
> Why is this a loop?

The 'Always Translate' button doesn't show up until a user has clicked
'Translate' for a language 'several times'. 'Several times' seems like something
that can change, so I made the test flexible. It navigates and selects translate
until the button is showing.

Do I need better documentation of this fact, or is the existing comment enough?

[Paweł Hajdan Jr., 2010-08-06 18:22:37]

On 2010/08/06 18:00:23, Alyssa wrote:
> On 2010/08/06 17:54:17, Paweł Hajdan Jr. wrote:
> > Drive-by with a test question.
> > 
> > http://codereview.chromium.org/3061054/diff/4001/8
> > File chrome/test/functional/translate.py (right):
> > 
> > http://codereview.chromium.org/3061054/diff/4001/8#newcode331
> > chrome/test/functional/translate.py:331: while not
> > self.GetTranslateInfo()['translate_bar']\
> > Why is this a loop?
> 
> The 'Always Translate' button doesn't show up until a user has clicked
> 'Translate' for a language 'several times'. 'Several times' seems like
something
> that can change, so I made the test flexible. It navigates and selects
translate
> until the button is showing.
> 
> Do I need better documentation of this fact, or is the existing comment
enough?

Please update the comment. What you said above is sufficient ("The Always
Translate button doesn't show up until the user has clicked Translate for a
language several times.").

[Alyssa, 2010-08-06 21:06:29]

On 2010/08/06 18:22:37, Paweł Hajdan Jr. wrote:
> On 2010/08/06 18:00:23, Alyssa wrote:
> > On 2010/08/06 17:54:17, Paweł Hajdan Jr. wrote:
> > > Drive-by with a test question.
> > > 
> > > http://codereview.chromium.org/3061054/diff/4001/8
> > > File chrome/test/functional/translate.py (right):
> > > 
> > > http://codereview.chromium.org/3061054/diff/4001/8#newcode331
> > > chrome/test/functional/translate.py:331: while not
> > > self.GetTranslateInfo()['translate_bar']\
> > > Why is this a loop?
> > 
> > The 'Always Translate' button doesn't show up until a user has clicked
> > 'Translate' for a language 'several times'. 'Several times' seems like
> something
> > that can change, so I made the test flexible. It navigates and selects
> translate
> > until the button is showing.
> > 
> > Do I need better documentation of this fact, or is the existing comment
> enough?
> 
> Please update the comment. What you said above is sufficient ("The Always
> Translate button doesn't show up until the user has clicked Translate for a
> language several times.").

Done.

[Paweł Hajdan Jr., 2010-08-06 21:24:58]

Code I commented in the drive-by LGTM.

[Nirnimesh, 2010-08-06 22:29:19]

http://codereview.chromium.org/3061054/diff/10001/11003
File chrome/test/functional/translate.py (right):

http://codereview.chromium.org/3061054/diff/10001/11003#newcode332
chrome/test/functional/translate.py:332: while not
self.GetTranslateInfo()['translate_bar']\
We should have an upper limit on the number of retries.
Otherwise, if there's a bug in chrome and the 'Always translate' button doesn't
show up, the test will hang forever.

Is 10 tries reasonable? Try 10 times and fail if we don't get the button until
then.

[Alyssa, 2010-08-09 17:08:10]

http://codereview.chromium.org/3061054/diff/10001/11003
File chrome/test/functional/translate.py (right):

http://codereview.chromium.org/3061054/diff/10001/11003#newcode332
chrome/test/functional/translate.py:332: while not
self.GetTranslateInfo()['translate_bar']\
On 2010/08/06 22:29:19, Nirnimesh wrote:
> We should have an upper limit on the number of retries.
> Otherwise, if there's a bug in chrome and the 'Always translate' button
doesn't
> show up, the test will hang forever.
> 
> Is 10 tries reasonable? Try 10 times and fail if we don't get the button until
> then.

10 tries seems reasonable. It currently shows after 3, so I don't see that limit
changing to be more than 10.

[Alyssa, 2010-08-10 00:25:23]

Nirnimesh - are you still reviewing, or is this ok to go in?

On 2010/08/09 17:08:10, Alyssa wrote:
> http://codereview.chromium.org/3061054/diff/10001/11003
> File chrome/test/functional/translate.py (right):
> 
> http://codereview.chromium.org/3061054/diff/10001/11003#newcode332
> chrome/test/functional/translate.py:332: while not
> self.GetTranslateInfo()['translate_bar']\
> On 2010/08/06 22:29:19, Nirnimesh wrote:
> > We should have an upper limit on the number of retries.
> > Otherwise, if there's a bug in chrome and the 'Always translate' button
> doesn't
> > show up, the test will hang forever.
> > 
> > Is 10 tries reasonable? Try 10 times and fail if we don't get the button
until
> > then.
> 
> 10 tries seems reasonable. It currently shows after 3, so I don't see that
limit
> changing to be more than 10.

[Nirnimesh, 2010-08-10 00:28:08]

LGTM