Issue 3061053: Fix the call to setClearingState which was causing a javascript error....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3061053: Fix the call to setClearingState which was causing a javascript error.... (Closed)

Created:
10 years, 4 months ago by csilv

Modified:
9 years, 7 months ago

Reviewers:
dhg

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix the call to setClearingState which was causing a javascript error. BUG=none TEST=Verify that dom-ui options window shows no javascript errors in the dev-tools panel. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55082

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/options/clear_browser_data_overlay.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dhg

10 years, 4 months ago (2010-08-05 15:39:04 UTC) #2

LGTM

On Wed, Aug 4, 2010 at 5:45 PM,  <csilv@chromium.org> wrote:
> Reviewers: dhg,
>
> Message:
> +dhg for review.
>
> Description:
> Fix the call to setClearingState which was causing a javascript error.
>
> BUG=none
> TEST=Verify that dom-ui options window shows no javascript errors in the
> dev-tools panel.
>
> Please review this at http://codereview.chromium.org/3061053/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/resources/options/clear_browser_data_overlay.js
>
>
> Index: chrome/browser/resources/options/clear_browser_data_overlay.js
> ===================================================================
> --- chrome/browser/resources/options/clear_browser_data_overlay.js
>  (revision 54963)
> +++ chrome/browser/resources/options/clear_browser_data_overlay.js
>  (working copy)
> @@ -75,7 +75,7 @@
>
>   ClearBrowserDataOverlay.dismiss = function() {
>     OptionsPage.clearOverlays();
> -    setClearingState(false);
> +    this.setClearingState(false);
>   }
>
>   // Export
>
>
>

Expand Messages | Collapse Messages