Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 3061051: Adding \n's to some files so that try bots can work for changes that actually... (Closed)

Created:
10 years, 4 months ago by tommi (sloooow) - chröme
Modified:
9 years, 7 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Adding \n's to some files so that try bots can work for changes that actually do something. TBR=amit TEST=n/a BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome_frame/test/ie_event_sink.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome_frame/test/mock_ie_event_sink_actions.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome_frame/test/mock_ie_event_sink_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome_frame/test/ui_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome_frame/utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tommi (sloooow) - chröme
10 years, 4 months ago (2010-08-04 20:17:21 UTC) #1
amit
10 years, 4 months ago (2010-08-04 22:06:26 UTC) #2
Thanks! Rubber stamp lgtm :)

On Wed, Aug 4, 2010 at 1:17 PM, <tommi@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Adding \n's to some files so that try bots can work for changes that
> actually do
> something.
>
> TBR=amit
> TEST=n/a
> BUG=none
>
>
> Please review this at http://codereview.chromium.org/3061051/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/ie_event_sink.h
>  M     chrome_frame/test/mock_ie_event_sink_actions.h
>  M     chrome_frame/test/mock_ie_event_sink_test.cc
>  M     chrome_frame/test/ui_test.cc
>  M     chrome_frame/utils.cc
>
>
> Index: chrome_frame/test/ie_event_sink.h
> ===================================================================
> --- chrome_frame/test/ie_event_sink.h   (revision 54898)
> +++ chrome_frame/test/ie_event_sink.h   (working copy)
> @@ -231,4 +231,5 @@
>
>  }  // namespace chrome_frame_test
>
> -#endif  // CHROME_FRAME_TEST_IE_EVENT_SINK_H_
> \ No newline at end of file
> +#endif  // CHROME_FRAME_TEST_IE_EVENT_SINK_H_
> +
> Index: chrome_frame/test/mock_ie_event_sink_actions.h
> ===================================================================
> --- chrome_frame/test/mock_ie_event_sink_actions.h      (revision 54898)
> +++ chrome_frame/test/mock_ie_event_sink_actions.h      (working copy)
> @@ -175,4 +175,5 @@
>
>  }  // namespace chrome_frame_test
>
> -#endif  // CHROME_FRAME_TEST_MOCK_IE_EVENT_SINK_ACTIONS_H_
> \ No newline at end of file
> +#endif  // CHROME_FRAME_TEST_MOCK_IE_EVENT_SINK_ACTIONS_H_
> +
> Index: chrome_frame/test/mock_ie_event_sink_test.cc
> ===================================================================
> --- chrome_frame/test/mock_ie_event_sink_test.cc        (revision 54898)
> +++ chrome_frame/test/mock_ie_event_sink_test.cc        (working copy)
> @@ -169,4 +169,5 @@
>   return server_mock_.Resolve(relative_path.c_str());
>  }
>
> -}  // namespace chrome_frame_test
> \ No newline at end of file
> +}  // namespace chrome_frame_test
> +
> Index: chrome_frame/test/ui_test.cc
> ===================================================================
> --- chrome_frame/test/ui_test.cc        (revision 54898)
> +++ chrome_frame/test/ui_test.cc        (working copy)
> @@ -538,4 +538,5 @@
>   LaunchIEAndNavigate(page1);
>  }
>
> -}  // namespace chrome_frame_test
> \ No newline at end of file
> +}  // namespace chrome_frame_test
> +
> Index: chrome_frame/utils.cc
> ===================================================================
> --- chrome_frame/utils.cc       (revision 54919)
> +++ chrome_frame/utils.cc       (working copy)
> @@ -1370,3 +1370,4 @@
>
>   return true;
>  }
> +
>
>
>

Powered by Google App Engine
This is Rietveld 408576698