Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 3061045: Add a customize_image script. (Closed)

Created:
10 years, 4 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
gauravsh, djmm
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Add a customize_image script. For now, it just updates the root password. BUG=5080 TEST=ran the script,tried the image

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
A scripts/image_signing/customize_image View 1 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
petkov
10 years, 4 months ago (2010-08-03 00:29:30 UTC) #1
gauravsh
LGTM with comment about comments http://codereview.chromium.org/3061045/diff/1/2 File scripts/image_signing/customize_image (right): http://codereview.chromium.org/3061045/diff/1/2#newcode10 scripts/image_signing/customize_image:10: # Usage: ./customize_image <image.bin> ...
10 years, 4 months ago (2010-08-03 03:16:00 UTC) #2
petkov
10 years, 4 months ago (2010-08-03 17:01:40 UTC) #3
Pushing...

http://codereview.chromium.org/3061045/diff/1/2
File scripts/image_signing/customize_image (right):

http://codereview.chromium.org/3061045/diff/1/2#newcode10
scripts/image_signing/customize_image:10: # Usage: ./customize_image <image.bin>
<password>
On 2010/08/03 03:16:00, gauravsh wrote:
> add a comment about what the password is for and what kind of customizations
the
> script does (right now it changes the password).

Done.

Powered by Google App Engine
This is Rietveld 408576698