Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 3061041: Add the definition of the webRequest and webNavigation APIs. (Closed)

Created:
10 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, yzshen
Visibility:
Public.

Description

Add the definition of the webRequest and webNavigation APIs. The webRequest API doesn't support the planned filter and extraInfoSpec parameters yet, these will be added later. BUG=50943 TEST=ExtensionApiTest.WebRequest,ExtensionApiTest.WebNavigation Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54723

Patch Set 1 #

Total comments: 8

Patch Set 2 : updates #

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
please review.
10 years, 4 months ago (2010-08-02 14:24:38 UTC) #1
yzshen
Hi, Jochen. Thanks for sending this out so quickly! http://codereview.chromium.org/3061041/diff/1/5 File chrome/common/extensions/api/extension_api.json (right): http://codereview.chromium.org/3061041/diff/1/5#newcode3009 chrome/common/extensions/api/extension_api.json:3009: ...
10 years, 4 months ago (2010-08-02 21:07:54 UTC) #2
Matt Perry
LGTM
10 years, 4 months ago (2010-08-03 00:57:59 UTC) #3
jochen (gone - plz use gerrit)
10 years, 4 months ago (2010-08-03 08:38:25 UTC) #4
http://codereview.chromium.org/3061041/diff/1/5
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/3061041/diff/1/5#newcode3009
chrome/common/extensions/api/extension_api.json:3009: "requestId": {"type":
"integer", "description": "The ID of the request to retrieve the document of
this navigation. Note that this event is fired prior to the corresponding
chrome.webRequest.onBeforeRequest."},
On 2010/08/02 21:07:54, yzshen wrote:
> Currently I think it should be chrome.experimental.webRequest.onBeforeRequest

Done.

http://codereview.chromium.org/3061041/diff/1/5#newcode3027
chrome/common/extensions/api/extension_api.json:3027: "transitionType": {"type":
"string", "description": "Cause of the navigation. Set to null for subframe
navigations. Please refer to the transition types below for detailed
explanation."},
On 2010/08/02 21:07:54, yzshen wrote:
> The transition types are not defined below.

Done.

http://codereview.chromium.org/3061041/diff/1/5#newcode3120
chrome/common/extensions/api/extension_api.json:3120: "tabId": {"type":
"integer", "description": "The ID of the tab in which the request takes place.
Set to null if the request isn't related to a tab."},
On 2010/08/02 21:07:54, yzshen wrote:
> There is a "method" property in the design doc. Is that also postponed to
later
> CLs?

Done.

http://codereview.chromium.org/3061041/diff/1/5#newcode3121
chrome/common/extensions/api/extension_api.json:3121: "type": {"type": "string",
"description": "Please refer to the request types below for detailed
explanation."},
On 2010/08/02 21:07:54, yzshen wrote:
> Request types are not defined below.

Done.

Powered by Google App Engine
This is Rietveld 408576698