Issue 3061023: GTK: Fix some event coordinate logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3061023: GTK: Fix some event coordinate logic (Closed)

Created:
10 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

GTK: Fix some event coordinate logic BUG=none TEST=you can still drag the chrome window by the titlebar, and when you double click it maximizes (this did not change; it was true before this patch as well) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54005

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/gtk/browser_window_gtk.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

Haha, nice. What is the symptom of this wrong logic? It'd be nice if you ...

10 years, 5 months ago (2010-07-27 23:06:51 UTC) #2

Evan Stade

10 years, 5 months ago (2010-07-27 23:15:35 UTC) #3

On 2010/07/27 23:06:51, Evan Martin wrote:
> Haha, nice.  What is the symptom of this wrong logic?  It'd be nice if you
could
> at least put TEST=[foobar] still works in.
> 
> LGTM anyway

it's pretty border-case. If you click twice while doing a quick down-left
movement of your mouse on the titlebar, the second click should be able to start
a drag. It didn't. Now it does.

Expand Messages | Collapse Messages