Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: chrome/browser/dom_ui/dom_ui_thumbnail_source.cc

Issue 3061009: Speculative fix for crash in DOMUIThumbnailSource. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: msvc++ caught this Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/dom_ui_thumbnail_source.h ('k') | chrome/browser/dom_ui/most_visited_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
diff --git a/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc b/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
index a89c92f61ae1da728ce52f1f165966154c42a554..6e18bd4a7f7c5af2b1a31a904955202e0f6fe66a 100644
--- a/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
+++ b/chrome/browser/dom_ui/dom_ui_thumbnail_source.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -22,9 +22,14 @@ DOMUIThumbnailSource::DOMUIThumbnailSource(Profile* profile)
profile_(profile) {
}
+DOMUIThumbnailSource::~DOMUIThumbnailSource() {
+ DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
+}
+
void DOMUIThumbnailSource::StartDataRequest(const std::string& path,
bool is_off_the_record,
int request_id) {
+ DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kTopSites)) {
scoped_refptr<history::TopSites> top_sites = profile_->GetTopSites();
RefCountedBytes* data = NULL;
@@ -51,6 +56,12 @@ void DOMUIThumbnailSource::StartDataRequest(const std::string& path,
}
}
+std::string DOMUIThumbnailSource::GetMimeType(const std::string&) const {
+ // We need to explicitly return a mime type, otherwise if the user tries to
+ // drag the image they get no extension.
+ return "image/png";
+}
+
void DOMUIThumbnailSource::SendDefaultThumbnail(int request_id) {
// Use placeholder thumbnail.
if (!default_thumbnail_.get()) {
@@ -64,6 +75,7 @@ void DOMUIThumbnailSource::SendDefaultThumbnail(int request_id) {
void DOMUIThumbnailSource::OnThumbnailDataAvailable(
HistoryService::Handle request_handle,
scoped_refptr<RefCountedBytes> data) {
+ DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
HistoryService* hs =
profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
int request_id = cancelable_consumer_.GetClientData(hs, request_handle);
« no previous file with comments | « chrome/browser/dom_ui/dom_ui_thumbnail_source.h ('k') | chrome/browser/dom_ui/most_visited_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698