Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/browser/views/location_bar_view.h

Issue 306059: Merge 29556 - Revert "Revert 29457, because this is making ExtensionBrowserTe... (Closed) Base URL: svn://chrome-svn/chrome/branches/223/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
Property Changes:
Modified: svn:mergeinfo
Merged /trunk/src/chrome/browser/views/location_bar_view.h:r29556
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_VIEWS_LOCATION_BAR_VIEW_H_ 5 #ifndef CHROME_BROWSER_VIEWS_LOCATION_BAR_VIEW_H_
6 #define CHROME_BROWSER_VIEWS_LOCATION_BAR_VIEW_H_ 6 #define CHROME_BROWSER_VIEWS_LOCATION_BAR_VIEW_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 Profile* profile, 349 Profile* profile,
350 const ExtensionAction* page_action, 350 const ExtensionAction* page_action,
351 const BubblePositioner* bubble_positioner); 351 const BubblePositioner* bubble_positioner);
352 virtual ~PageActionImageView(); 352 virtual ~PageActionImageView();
353 353
354 // Overridden from view for the mouse hovering. 354 // Overridden from view for the mouse hovering.
355 virtual bool OnMousePressed(const views::MouseEvent& event); 355 virtual bool OnMousePressed(const views::MouseEvent& event);
356 356
357 // Overridden from LocationBarImageView. 357 // Overridden from LocationBarImageView.
358 virtual void ShowInfoBubble(); 358 virtual void ShowInfoBubble();
359 virtual void Paint(gfx::Canvas* canvas);
359 360
360 // Overridden from ImageLoadingTracker. 361 // Overridden from ImageLoadingTracker.
361 virtual void OnImageLoaded(SkBitmap* image, size_t index); 362 virtual void OnImageLoaded(SkBitmap* image, size_t index);
362 363
363 // Called to notify the PageAction that it should determine whether to be 364 // Called to notify the PageAction that it should determine whether to be
364 // visible or hidden. |contents| is the TabContents that is active, |url| 365 // visible or hidden. |contents| is the TabContents that is active, |url|
365 // is the current page URL. 366 // is the current page URL.
366 void UpdateVisibility(TabContents* contents, GURL url); 367 void UpdateVisibility(TabContents* contents, GURL url);
367 368
368 private: 369 private:
(...skipping 18 matching lines...) Expand all
387 int current_tab_id_; 388 int current_tab_id_;
388 389
389 // The URL we are currently showing the icon for. 390 // The URL we are currently showing the icon for.
390 GURL current_url_; 391 GURL current_url_;
391 392
392 // The string to show for a tooltip; 393 // The string to show for a tooltip;
393 std::string tooltip_; 394 std::string tooltip_;
394 395
395 DISALLOW_COPY_AND_ASSIGN(PageActionImageView); 396 DISALLOW_COPY_AND_ASSIGN(PageActionImageView);
396 }; 397 };
398 friend class PageActionImageView;
397 399
398 // Both Layout and OnChanged call into this. This updates the contents 400 // Both Layout and OnChanged call into this. This updates the contents
399 // of the 3 views: selected_keyword, keyword_hint and type_search_view. If 401 // of the 3 views: selected_keyword, keyword_hint and type_search_view. If
400 // force_layout is true, or one of these views has changed in such a way as 402 // force_layout is true, or one of these views has changed in such a way as
401 // to necessitate a layout, layout occurs as well. 403 // to necessitate a layout, layout occurs as well.
402 void DoLayout(bool force_layout); 404 void DoLayout(bool force_layout);
403 405
404 // Returns the height in pixels of the margin at the top of the bar. 406 // Returns the height in pixels of the margin at the top of the bar.
405 int TopMargin() const; 407 int TopMargin() const;
406 408
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
528 // The positioner that places the omnibox and info bubbles. 530 // The positioner that places the omnibox and info bubbles.
529 const BubblePositioner* bubble_positioner_; 531 const BubblePositioner* bubble_positioner_;
530 532
531 // Storage of string needed for accessibility. 533 // Storage of string needed for accessibility.
532 std::wstring accessible_name_; 534 std::wstring accessible_name_;
533 535
534 DISALLOW_COPY_AND_ASSIGN(LocationBarView); 536 DISALLOW_COPY_AND_ASSIGN(LocationBarView);
535 }; 537 };
536 538
537 #endif // CHROME_BROWSER_VIEWS_LOCATION_BAR_VIEW_H_ 539 #endif // CHROME_BROWSER_VIEWS_LOCATION_BAR_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/views/browser_actions_container.cc ('k') | chrome/browser/views/location_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698