Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 306051: Add AUTHORS and LICENSE files, and copyright headers to relevant source files... (Closed)

Created:
11 years, 2 months ago by sgk
Modified:
9 years, 5 months ago
CC:
gyp-developer_googlegroups.com, bradnelson
Visibility:
Public.

Description

Add AUTHORS and LICENSE files, and copyright headers to relevant source files. BUG=62 TEST=none Committed: http://code.google.com/p/gyp/source/detail?r=721

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+675 lines, -5 lines) Patch
A trunk/AUTHORS View 1 1 chunk +5 lines, -0 lines 2 comments Download
A trunk/LICENSE View 1 1 chunk +27 lines, -0 lines 0 comments Download
M trunk/gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/gyp.bat View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/gyptest.py View 1 1 chunk +8 lines, -5 lines 0 comments Download
M trunk/pylib/gyp/MSVSNew.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/MSVSProject.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/MSVSToolFile.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/MSVSUserFile.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/MSVSVersion.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/SCons.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/__init__.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/common.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/generator/gypd.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/generator/gypsh.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/generator/make.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/generator/msvs.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/generator/scons.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/generator/xcode.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/input.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/pylib/gyp/xcodeproj_file.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/samples/samples View 1 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/samples/samples.bat View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions-bare/gyptest-bare.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions-bare/src/bare.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions-bare/src/bare.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
trunk/test/actions-subdir/gyptest-action.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions-subdir/src/make-file.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions-subdir/src/none.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions-subdir/src/subdir/make-subdir-file.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions-subdir/src/subdir/subdir.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions/gyptest-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions/gyptest-default.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions/gyptest-errors.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions/src/action_missing_name.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions/src/actions.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions/src/subdir1/executable.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions/src/subdir1/make-prog1.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/test/actions/src/subdir1/make-prog2.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/test/actions/src/subdir2/make-file.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions/src/subdir2/none.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions/src/subdir3/generate_main.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/actions/src/subdir3/null_input.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/additional-targets/gyptest-additional.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/additional-targets/src/all.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/additional-targets/src/dir1/actions.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/additional-targets/src/dir1/emit.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/assembly/gyptest-assembly.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/assembly/src/assembly.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/builddir/gyptest-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/builddir/gyptest-default.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/builddir/src/builddir.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/builddir/src/prog1.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/builddir/src/subdir2/prog2.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/builddir/src/subdir2/subdir3/prog3.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/builddir/src/subdir2/subdir3/subdir4/prog4.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/builddir/src/subdir2/subdir3/subdir4/subdir5/prog5.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/compilable/gyptest-headers.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/compilable/src/headers.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/configurations/configurations.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/configurations/gyptest-configurations.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/copies-link/gyptest-copies-link.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/copies-link/src/copies-link.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/copies-link/src/copy.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/copies/gyptest-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/copies/gyptest-default.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
trunk/test/copies/src/copies.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/defines/defines.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/defines/defines-env.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/defines/gyptest-defines.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/defines/gyptest-defines-env.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/defines/gyptest-defines-env-regyp.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/dependencies/b/b.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/dependencies/c/c.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/dependencies/extra_targets.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/dependencies/gyptest-extra-targets.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/dependencies/gyptest-lib-only.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/dependencies/lib_only.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/dependency-copy/gyptest-copy.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/dependency-copy/src/copies.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/actions/actions.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/actions/subdir1/executable.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/actions/subdir1/make-prog1.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/test/generator-output/actions/subdir1/make-prog2.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/test/generator-output/actions/subdir2/make-file.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/actions/subdir2/none.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/copies/copies.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/copies/subdir/subdir.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/gyptest-actions.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/gyptest-copies.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/gyptest-relocate.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/gyptest-rules.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/gyptest-subdir2-deep.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/gyptest-top-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/rules/copy-file.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/test/generator-output/rules/rules.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/rules/subdir1/executable.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/rules/subdir2/none.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/src/prog1.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/src/subdir2/deeper/deeper.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/src/subdir2/prog2.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/src/subdir3/prog3.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/generator-output/src/symroot.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/hello/gyptest-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/hello/gyptest-default.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/hello/gyptest-disable-regyp.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/hello/gyptest-regyp.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/hello/gyptest-target.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/hello/hello.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/hello/hello2.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/include_dirs/gyptest-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/include_dirs/gyptest-default.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/include_dirs/src/includes.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/include_dirs/src/subdir/subdir_includes.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/lib/TestGyp.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/library/gyptest-shared.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/library/gyptest-static.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/library/src/library.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/module/gyptest-default.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/module/src/module.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/multiple-targets/gyptest-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/multiple-targets/gyptest-default.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/multiple-targets/src/multiple.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/no-output/gyptest-no-output.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/no-output/src/nooutput.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/rules/gyptest-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/rules/gyptest-default.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/rules/src/actions.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/rules/src/copy-file.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/rules/src/subdir1/executable.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/rules/src/subdir2/none.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/same-name/gyptest-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/same-name/gyptest-default.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/same-name/src/all.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/scons_tools/gyptest-tools.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/scons_tools/site_scons/site_tools/this_tool.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/scons_tools/tools.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/sibling/gyptest-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/sibling/gyptest-relocate.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/sibling/src/build/all.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/sibling/src/prog1/prog1.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/sibling/src/prog2/prog2.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/subdirectory/gyptest-SYMROOT-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/subdirectory/gyptest-SYMROOT-default.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/subdirectory/gyptest-subdir-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/subdirectory/gyptest-subdir-default.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/subdirectory/gyptest-subdir2-deep.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/subdirectory/gyptest-top-all.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/subdirectory/gyptest-top-default.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/subdirectory/src/prog1.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/subdirectory/src/subdir/prog2.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/subdirectory/src/subdir/subdir2/prog3.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/subdirectory/src/symroot.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/toolsets/gyptest-toolsets.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/toolsets/toolsets.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/variables/commands.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/variables/commands.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/variables/gyptest-commands.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/variables/gyptest-commands-ignore-env.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/variants/gyptest-variants.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/test/variants/src/variants.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sgk
I cut-and-pasted from Chromiuim the LICENSE and AUTHORS (initial template, just lists "Google Inc."). The ...
11 years, 2 months ago (2009-10-22 17:46:49 UTC) #1
Mark Mentovai
Rubber-stamp, I just looked at the first few files. http://codereview.chromium.org/306051/diff/1/157 File trunk/LICENSE (right): http://codereview.chromium.org/306051/diff/1/157#newcode1 Line ...
11 years, 2 months ago (2009-10-22 18:13:34 UTC) #2
sgk
http://codereview.chromium.org/306051/diff/1/157 File trunk/LICENSE (right): http://codereview.chromium.org/306051/diff/1/157#newcode1 Line 1: Copyright (c) 2009 Google, Inc. All rights reserved. ...
11 years, 2 months ago (2009-10-22 20:00:55 UTC) #3
Mark Mentovai
Rubber stamp still stands. http://codereview.chromium.org/306051/diff/4001/4161 File trunk/AUTHORS (right): http://codereview.chromium.org/306051/diff/4001/4161#newcode5 Line 5: Steven Knight <knight@baldmt.com> We ...
11 years, 2 months ago (2009-10-22 20:07:20 UTC) #4
sgk
11 years, 2 months ago (2009-10-22 20:24:30 UTC) #5
http://codereview.chromium.org/306051/diff/4001/4161
File trunk/AUTHORS (right):

http://codereview.chromium.org/306051/diff/4001/4161#newcode5
Line 5: Steven Knight <knight@baldmt.com>
On 2009/10/22 20:07:20, Mark Mentovai wrote:
> We didn't do this for Chromium.  Maybe Danny has an opinion?
> 
> If we're gonna do this, we should seed the list with all of our names?

I think this is a special case.  I put my name and address in there because I
contributed two modules (test/lib/Test{Cmd,Common}.py) that preceded my Google
time and which are already copyright me (2004).  I figured that having the name
and address in there would answer any future questions about whether those two
modules are included legitimately, without having to get actual people involved.
 Probably should have checked first (IANAL, etc.); if that seems mistaken, let
me know.

Powered by Google App Engine
This is Rietveld 408576698